Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ruff #27

Merged
merged 5 commits into from
Feb 16, 2024
Merged

Use ruff #27

merged 5 commits into from
Feb 16, 2024

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Feb 13, 2024

Progress of the PR

  • Use ruff for linting and formatting,
  • remove lint GitHub workflow as it is redundant with pre-commit,
  • [n/a] docstring updated (if appropriate),
  • [n/a] update user guide (if appropriate),
  • [n/a] added tests,
  • add a changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting of the changelog entry (and eventual user guide changes) in the docs/readthedocs.org:exspy build of this PR (link in github checks)
  • ready for review.

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (bc2cbbd) 88.09% compared to head (46d213a) 88.07%.

Files Patch % Lines
exspy/misc/eels/tools.py 0.00% 6 Missing ⚠️
exspy/components/eels_vignetting.py 0.00% 2 Missing ⚠️
exspy/conftest.py 75.00% 0 Missing and 1 partial ⚠️
exspy/misc/eels/eelsdb.py 0.00% 1 Missing ⚠️
exspy/tests/signals/test_eels.py 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   88.09%   88.07%   -0.03%     
==========================================
  Files          67       67              
  Lines        7289     7276      -13     
  Branches     1176     1179       +3     
==========================================
- Hits         6421     6408      -13     
+ Misses        593      591       -2     
- Partials      275      277       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericpre ericpre added this to the v0.2 milestone Feb 14, 2024
exspy/tests/components/test_double_power_law.py Outdated Show resolved Hide resolved
This directory contains "news fragments" which are short files that contain a small **ReST**-formatted
text that will be added to the next ``CHANGELOG``.

The ``CHANGELOG`` will be read by **users**, so this description should be aimed to hyperspy users
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The ``CHANGELOG`` will be read by **users**, so this description should be aimed to hyperspy users
The ``CHANGELOG`` will be read by **users**, so this description should be aimed to eXSpy users

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only noticed that you already added this file in #22. Will rebase after #22 is merged.

@ericpre ericpre merged commit dfd6a52 into hyperspy:main Feb 16, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants