Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cred migrator #867

Merged
merged 59 commits into from
Jul 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
7ae1ed3
Created additional crate
bobozaur May 28, 2023
1a0cb89
Added aries_vcx_core dependency
bobozaur May 28, 2023
2d255ce
Remove obsolete comment
bobozaur May 30, 2023
82a29a4
Added infrastructure for import_and_migrate
bobozaur Jun 1, 2023
d127444
Added comments
bobozaur Jun 1, 2023
3c71727
Drafted test for migration
bobozaur Jun 1, 2023
c20acfb
Refactored migration to avoid encryption and intermediary file
bobozaur Jun 12, 2023
a7d7ee8
Cosmetic change
bobozaur Jun 12, 2023
6e16aee
Simplified test
bobozaur Jun 12, 2023
10a5fd1
Removed aries_vcx_core dep from cred_migrator
bobozaur Jun 12, 2023
d88dd32
Cleanup
bobozaur Jun 12, 2023
8e7fd07
Renamed migration method for consistency
bobozaur Jun 12, 2023
873fb7a
Cleanup v2
bobozaur Jun 12, 2023
8cd4de0
Reverted wallet handle to pub
bobozaur Jun 12, 2023
e265b54
Made migrate closures return a Result<Option<Record, Err>> to be able…
bobozaur Jun 12, 2023
0717046
Error tweaks in vdrtools and better errors in migrator
bobozaur Jun 13, 2023
88998ac
Added conversions for vdrtools2credx
bobozaur Jun 13, 2023
8f18aed
Remove commented out Indy record types
bobozaur Jun 14, 2023
70e63f2
Added constants for Indy categories
bobozaur Jun 14, 2023
e92e9a9
Removed commented indy types
bobozaur Jun 14, 2023
5445bcd
Test updates
bobozaur Jun 15, 2023
c189b61
Fix CredentialKeyCorrectnessProof conversion
bobozaur Jun 16, 2023
3752b4c
Added revocation registry types to conversion testing
bobozaur Jun 16, 2023
c50d713
Commented test
bobozaur Jun 16, 2023
f6c3afd
Initial integration tests for migration in aries-vcx
bobozaur Jun 21, 2023
e5abcef
Fix SchemaId wallet storage & retrieval
bobozaur Jun 21, 2023
33da054
Added revocation tests for migration
bobozaur Jun 21, 2023
d5d17f1
Cosmetic change
bobozaur Jun 21, 2023
dd2d27a
Removed extra test files in favor of feature controller migration
bobozaur Jun 22, 2023
9ad148f
Added migration job to CI
bobozaur Jun 22, 2023
98523bb
Narrow down the migration tests
bobozaur Jun 22, 2023
f2b1a06
Refinement of the migration CI job
bobozaur Jun 22, 2023
d1df155
Renamed cred_migrator to wallet_migrator
bobozaur Jun 22, 2023
5245abb
Fixed GH action YAML file
bobozaur Jun 22, 2023
c82a733
Fixes post crate rename
bobozaur Jun 22, 2023
132105d
Added deserialization among conversion methods for double-checking
bobozaur Jun 22, 2023
0d25f2b
Put the wallet_handle Profile method behind the migration feature flag
bobozaur Jun 22, 2023
b49adfe
Feature flagged the migration module in integration tests
bobozaur Jun 22, 2023
212e269
Fixed modular profile build for agent entity
bobozaur Jun 22, 2023
40f4d7c
Added mysql wallet migration test and integrated sqlx migration into …
bobozaur Jun 26, 2023
d5875ef
Added crate testing for wallet_migrator in CI
bobozaur Jun 26, 2023
6e437c9
Ran cargo fmt
bobozaur Jun 26, 2023
7d13418
Added requested test scenario for migration
bobozaur Jun 26, 2023
565d76b
Fixed mysql create_storage and relaxed lint checking in libvdrtools
bobozaur Jun 26, 2023
6287f1b
Ran cargo fmt
bobozaur Jun 26, 2023
21dc687
Fixed new test
bobozaur Jun 26, 2023
72d7d8c
Fix parameter binding in db creation query
bobozaur Jun 27, 2023
08ccd2d
Fixed mysql table creation
bobozaur Jun 27, 2023
237b456
Fixed some lints
bobozaur Jun 27, 2023
f013b00
Fixed Revocation Registry Delta migration
bobozaur Jun 28, 2023
55be22a
Fixed credential issuance after revoking locally
bobozaur Jun 29, 2023
23d7c20
Added comment for issuer create credential ID qualification
bobozaur Jun 29, 2023
8e7af99
Ran cargo fmt
bobozaur Jun 29, 2023
e9f334d
Fixed dummy rev_reg_delta creation - to match vdrtools impl
bobozaur Jun 29, 2023
0c97fba
Added trace logs for converted record of the migration
bobozaur Jun 30, 2023
df17a60
Added record count logging for migration
bobozaur Jun 30, 2023
26fb944
Get rid of the 'id' column and revert the PK in the 'items' table
bobozaur Jun 30, 2023
236d04e
Improved migrator logging
bobozaur Jun 30, 2023
036747d
Changed migration signature to accept two WalletHandle instances
bobozaur Jul 3, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,7 @@ jobs:
with:
skip-docker-setup: true
- name: "Run workspace tests: general_test"
run: RUST_TEST_THREADS=1 cargo test --workspace --lib --exclude aries-vcx-agent --exclude libvdrtools
run: RUST_TEST_THREADS=1 cargo test --workspace --lib --exclude aries-vcx-agent --exclude libvdrtools --exclude wallet_migrator

test-integration-aries-vcx:
needs: workflow-setup
Expand Down Expand Up @@ -544,6 +544,20 @@ jobs:
- name: "Run aries-vcx tests: pool_tests agency_pool_tests"
run: RUST_TEST_THREADS=1 cargo test --manifest-path="aries_vcx/Cargo.toml" -F mixed_breed -- --include-ignored;

test-integration-aries-vcx-migration:
needs: workflow-setup
runs-on: ubuntu-20.04
steps:
- name: "Git checkout"
uses: actions/checkout@v3
- name: "Setup rust testing environment"
uses: ./.github/actions/setup-testing-rust
- name: "Run aries-vcx tests: pool_tests agency_pool_tests"
run: |
cargo test --manifest-path="wallet_migrator/Cargo.toml";
RUST_TEST_THREADS=1 CARGO_INCREMENTAL=0 TEST_POOL_IP=127.0.0.1 cargo test --manifest-path="aries_vcx/Cargo.toml" -F migration --test test_creds_proofs -- --include-ignored;
RUST_TEST_THREADS=1 CARGO_INCREMENTAL=0 TEST_POOL_IP=127.0.0.1 cargo test --manifest-path="aries_vcx/Cargo.toml" -F migration --test test_creds_proofs_revocations -- --include-ignored;

test-integration-libvcx:
needs: workflow-setup
if: ${{ needs.workflow-setup.outputs.SKIP_CI != 'true' }}
Expand Down
199 changes: 30 additions & 169 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading