-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/cred migrator #867
Conversation
Codecov Report
@@ Coverage Diff @@
## main #867 +/- ##
==========================================
- Coverage 49.89% 8.12% -41.78%
==========================================
Files 432 434 +2
Lines 35058 34783 -275
Branches 7617 7538 -79
==========================================
- Hits 17493 2826 -14667
- Misses 12287 31156 +18869
+ Partials 5278 801 -4477
Flags with carried forward coverage won't be shown. Click here to find out more.
|
606a990
to
268b4a2
Compare
69d4e17
to
e7dc9b4
Compare
d3b9a4e
to
beb2c77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left few comments
I'd suggest to work a little bit more on testing - the current approach includes migration to existing tests, but usually the migration happens at the same spot, after issuing credentials.
We could probably take some tests and tweak around the position of migration, but I think following scenario could deserve a dedicated test:
Scenario 1:
- create creddef, revocation registry
- issue credential A, revoke locally
- issue credential B
- migrate
- revoke locally B
- issue another credential C
- revoke locally C
- publish revocation
Mainly to check that revocation registries and accumulated deltas properly survive across the migration
@Patrik-Stas The requested test scenario was added. I'll be monitoring the CI to check on the latest changes, but apart from that I think the points you mentioned in your review are covered now. |
b3c048d
to
89be025
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments
50fb4b2
to
acab7bb
Compare
acab7bb
to
ac86550
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left further comment on logging
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
…libvdrtools Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
ac86550
to
236d04e
Compare
Signed-off-by: Bogdan Mircea <[email protected]>
This PR introduces the
wallet_migrator
library crate, currently just for the purpose of migrating anoncreds related objects from theirlibvdrtools
implementation toindy-credx
. This is accomplished by creating a newIndy
wallet, so the old one remains as a backup.The migrator is flexible enough though to support migrating anything in terms of an
Indy
wallet.In the future the crate could be extended to assist with migrating from an
Indy
wallet to a different one too.The PR also adds a testing feature (unfortunately necessary) to accommodate current tests in
aries-vcx
so that wallets get migrated in the middle of the tests to ensure things keep working post migration.Stubs are already in place for the
indy-credx
toanoncreds-rs
migration, but that will be fully implemented in a future PR.