Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always get endpoint and endpoints secrets in helm charts #3686

Merged
merged 4 commits into from
May 7, 2024

Conversation

tkporter
Copy link
Collaborator

@tkporter tkporter commented May 1, 2024

Description

Noticed that the logic used by the key funder's helm chart to decide whether to fetch endpoint (singular) or endpoints (plural) from secrets was stale. This is because fallback was introduced later, and the logic was looking for quorum - so with the key funder config saying we wanted to use fallback provider, we weren't ever fetching the plural endpoints from secrets

Imo the branching is a bit unnecessary and prone to becoming stale, so I removed it so that we just get both secrets from GCP secrets.

Also redeployed key funder to get the correct secrets

Drive-by changes

Related issues

Backward compatibility

Testing

@tkporter tkporter requested a review from nambrot as a code owner May 1, 2024 11:11
Copy link

changeset-bot bot commented May 1, 2024

⚠️ No Changeset found

Latest commit: 01c0905

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.42%. Comparing base (cc7e8d9) to head (01c0905).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3686   +/-   ##
=======================================
  Coverage   74.42%   74.42%           
=======================================
  Files         110      110           
  Lines        1228     1228           
  Branches      133      133           
=======================================
  Hits          914      914           
  Misses        297      297           
  Partials       17       17           
Components Coverage Δ
core 84.61% <ø> (ø)
hooks 69.94% <ø> (ø)
isms 73.17% <ø> (ø)
token 64.66% <ø> (ø)
middlewares 77.48% <ø> (ø)

@tkporter tkporter enabled auto-merge (squash) May 7, 2024 08:24
@tkporter tkporter merged commit 1cf6cca into main May 7, 2024
36 of 37 checks passed
@tkporter tkporter deleted the trevor/helm-always-get-endpoint-and-endpoints branch May 7, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants