Always get endpoint and endpoints secrets in helm charts #3686
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noticed that the logic used by the key funder's helm chart to decide whether to fetch endpoint (singular) or endpoints (plural) from secrets was stale. This is because fallback was introduced later, and the logic was looking for quorum - so with the key funder config saying we wanted to use fallback provider, we weren't ever fetching the plural endpoints from secrets
Imo the branching is a bit unnecessary and prone to becoming stale, so I removed it so that we just get both secrets from GCP secrets.
Also redeployed key funder to get the correct secrets
Drive-by changes
Related issues
Backward compatibility
Testing