-
Notifications
You must be signed in to change notification settings - Fork 407
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Always get endpoint and endpoints secrets in helm charts (#3686)
### Description Noticed that the logic used by the key funder's helm chart to decide whether to fetch endpoint (singular) or endpoints (plural) from secrets was stale. This is because fallback was introduced later, and the logic was looking for quorum - so with the key funder config saying we wanted to use fallback provider, we weren't ever fetching the plural endpoints from secrets Imo the branching is a bit unnecessary and prone to becoming stale, so I removed it so that we just get both secrets from GCP secrets. Also redeployed key funder to get the correct secrets ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests -->
- Loading branch information
Showing
3 changed files
with
0 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters