By default, don't overwrite pushgateway metrics #3492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
paulbalaji
approved these changes
Mar 26, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v2 #3492 +/- ##
=======================================
Coverage 67.91% 67.91%
=======================================
Files 95 95
Lines 1446 1446
Branches 189 189
=======================================
Hits 982 982
Misses 457 457
Partials 7 7
|
tkporter
added a commit
that referenced
this pull request
Apr 2, 2024
### Description - My changes in #3491 / #3492 were kind of accurate - according to prometheus/pushgateway#65 even using pushAdd will displace existing metrics. It's all very confusing! - I tested this with a script that pushed some test metrics to the push gateway - basically by having the key funder use a different job name than the mainnet2 one, the metrics each of them push won't conflict with one another ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests -->
yorhodes
pushed a commit
that referenced
this pull request
Apr 14, 2024
### Description - My changes in #3491 / #3492 were kind of accurate - according to prometheus/pushgateway#65 even using pushAdd will displace existing metrics. It's all very confusing! - I tested this with a script that pushed some test metrics to the push gateway - basically by having the key funder use a different job name than the mainnet2 one, the metrics each of them push won't conflict with one another ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests -->
letonchanh
pushed a commit
to letonchanh/hyperlane-monorepo
that referenced
this pull request
Apr 25, 2024
### Description - My changes in hyperlane-xyz#3491 / hyperlane-xyz#3492 were kind of accurate - according to prometheus/pushgateway#65 even using pushAdd will displace existing metrics. It's all very confusing! - I tested this with a script that pushed some test metrics to the push gateway - basically by having the key funder use a different job name than the mainnet2 one, the metrics each of them push won't conflict with one another ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests -->
daniel-savu
pushed a commit
that referenced
this pull request
Jun 5, 2024
### Description - v2 backport of #3491 ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drive-by changes
Related issues
Backward compatibility
Testing