Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enroll additional validators on v3 mainnet #2888

Merged
merged 11 commits into from
Nov 10, 2023
Merged

Conversation

nambrot
Copy link
Contributor

@nambrot nambrot commented Nov 3, 2023

Description

  • This PR adds the latest validators to the config

Drive-by changes

  • Fixes fork tests

Testing

  • test-env mainnet3 core

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #2888 (0ca9ebb) into v3 (e4ed2c3) will increase coverage by 0.09%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #2888      +/-   ##
==========================================
+ Coverage   67.94%   68.04%   +0.09%     
==========================================
  Files          99       99              
  Lines        1017     1017              
  Branches      106      106              
==========================================
+ Hits          691      692       +1     
  Misses        286      286              
+ Partials       40       39       -1     
Components Coverage Δ
core 50.00% <ø> (ø)
hooks 71.42% <ø> (ø)
isms 71.22% <ø> (+0.71%) ⬆️
token 58.41% <ø> (ø)
middlewares 81.46% <ø> (ø)

@nambrot
Copy link
Contributor Author

nambrot commented Nov 9, 2023

@yorhodes would love your eyes on this

@yorhodes yorhodes changed the title Add validators Enroll additional validators on v3 Nov 9, 2023
@yorhodes yorhodes changed the title Enroll additional validators on v3 Enroll additional validators on v3 mainnet Nov 9, 2023
@yorhodes yorhodes enabled auto-merge (squash) November 9, 2023 23:33
@yorhodes yorhodes merged commit 0302a28 into v3 Nov 10, 2023
25 checks passed
@yorhodes yorhodes deleted the nambrot/add-validators branch November 10, 2023 00:29
This was referenced Nov 10, 2023
yorhodes added a commit that referenced this pull request Jan 26, 2024
### Description

#2888 introduced
breaking changes to non-`arbitrum` chains but fork tests would not cover
This PR adds a `fork-all` script for running fork tests on all `protocol
== ethereum` chains in an environment
It also improves the interface of the `fork` script to accept a target
chain

### Drive-by changes

- Remove noisy `console.log`s
- swap `polygon, ethereum, polygonzkevm` RPCs
- Fixes `ownerOverrides: proxyAdmin` for chains without gnosis safes

### Backward compatibility

Yes
ltyu pushed a commit to ltyu/hyperlane-monorepo that referenced this pull request Mar 13, 2024
### Description

hyperlane-xyz#2888 introduced
breaking changes to non-`arbitrum` chains but fork tests would not cover
This PR adds a `fork-all` script for running fork tests on all `protocol
== ethereum` chains in an environment
It also improves the interface of the `fork` script to accept a target
chain

### Drive-by changes

- Remove noisy `console.log`s
- swap `polygon, ethereum, polygonzkevm` RPCs
- Fixes `ownerOverrides: proxyAdmin` for chains without gnosis safes

### Backward compatibility

Yes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants