Improve ergonomics of fork tests #2911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yorhodes
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2911 +/- ##
=======================================
Coverage 67.65% 67.65%
=======================================
Files 99 99
Lines 1014 1014
Branches 106 106
=======================================
Hits 686 686
Misses 284 284
Partials 44 44
|
|
yorhodes
changed the title
jmrossy
approved these changes
Jan 25, 2024
ltyu
pushed a commit
to ltyu/hyperlane-monorepo
that referenced
this pull request
Mar 13, 2024
### Description hyperlane-xyz#2888 introduced breaking changes to non-`arbitrum` chains but fork tests would not cover This PR adds a `fork-all` script for running fork tests on all `protocol == ethereum` chains in an environment It also improves the interface of the `fork` script to accept a target chain ### Drive-by changes - Remove noisy `console.log`s - swap `polygon, ethereum, polygonzkevm` RPCs - Fixes `ownerOverrides: proxyAdmin` for chains without gnosis safes ### Backward compatibility Yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#2888 introduced breaking changes to non-
arbitrumchains but fork tests would not coverThis PR adds a
fork-allscript for running fork tests on allprotocol == ethereumchains in an environmentIt also improves the interface of the
forkscript to accept a target chainDrive-by changes
console.logspolygon, ethereum, polygonzkevmRPCsownerOverrides: proxyAdminfor chains without gnosis safesBackward compatibility
Yes