Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor arm kinematics #311

Merged
merged 6 commits into from
Apr 16, 2024
Merged

Refactor arm kinematics #311

merged 6 commits into from
Apr 16, 2024

Conversation

abhaybd
Copy link
Member

@abhaybd abhaybd commented Apr 9, 2024

Now it's much more general to allow for different FK and IK algorithms, as well as non-planar kinematics. For convenience, all methods are wrapped in a general ArmKinematics class responsible for kinematic transformations.

Copy link
Member

@Geeoon Geeoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice anything besides what might be some commenting issues.
Looks good otherwise!

src/kinematics/InverseArmKinematics.h Outdated Show resolved Hide resolved
src/kinematics/InverseArmKinematics.h Outdated Show resolved Hide resolved
src/kinematics/ForwardArmKinematics.h Outdated Show resolved Hide resolved
src/kinematics/ForwardArmKinematics.h Outdated Show resolved Hide resolved
@abhaybd abhaybd requested a review from Geeoon April 12, 2024 00:50
Copy link
Member

@Geeoon Geeoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@huttongrabiel huttongrabiel merged commit 1ece44b into master Apr 16, 2024
3 checks passed
@huttongrabiel huttongrabiel deleted the refactor-ik branch April 16, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants