ROS 2 ouster os1 os0 #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
…into suggestions Signed-off-by: Jakub Delicat <[email protected]>
Suggestions
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
…into ros2-add-ur-component Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
rafal-gorecki
requested changes
May 28, 2024
urdf/components.urdf.xacro
Outdated
| @@ -71,18 +71,99 @@ | |||
| /> | |||
| </xacro:if> | |||
|
|
|||
| <xacro:if value="${type == 'LDR10'}"> | |||
There was a problem hiding this comment.
Probably all changes in this file can be reduced to:
<xacro:property name="ouster_models_dict" value="${{
'LDR10': 'os0_32',
'LDR11': 'os0_64',
'LDR12': 'os0_128',
'LDR13': 'os1_32',
'LDR14': 'os1_64',
'LDR15': 'os1_128'
}}" />
<xacro:if value="${type in ouster_models_dict}">
<xacro:include
filename="$(find ros_components_description)/urdf/ouster.urdf.xacro"
ns="lidar"
/>
<xacro:lidar.ouster
parent_link="${parent_link}"
xyz="${xyz}"
rpy="${rpy}"
namespace="${robot_namespace}"
device_namespace="${device_namespace}"
model="${ouster_models_dict[type]}"
/>
</xacro:if>There was a problem hiding this comment.
Great idea! Implemented
Signed-off-by: Jakub Delicat <[email protected]>
rafal-gorecki
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unified XACRo for Ousters OS0 and OS1
Check after this:
#44