Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ONNX conversion and pipeline for SD3 #8984

Closed
wants to merge 6 commits into from

Conversation

mengniwang95
Copy link

What does this PR do?

Support ONNX conversion and pipeline for SD3

scheduler=pipeline.scheduler,
)

onnx_pipeline.save_pretrained("sd3")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I have no access to upload ONNX SD3 model to hf-internal-testing, I export the ONNX model in UT. If anyone could help upload it, the code can be simplified.

@mengniwang95
Copy link
Author

@a-r-r-o-w Hi, could you please help to take a look?

@a-r-r-o-w a-r-r-o-w requested review from DN6 and sayakpaul July 30, 2024 10:32
@sayakpaul
Copy link
Member

I think this should go to Optimum. Cc: @echarlaix

@echarlaix
Copy link
Contributor

cc @IlyasMoutawwakil

@mengniwang95
Copy link
Author

I found SD ONNX conversion and ONNX pipeline are in diffusers so I added ONNX SD3 here. If you all think Optimum is more suitable, please guide me how should I organize it since there seems no ONNX SD related conversion script and pipeline in https://github.com/huggingface/optimum 😄
Thanks

Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Sep 14, 2024
"input_ids": {0: "batch", 1: "sequence"},
},
opset=opset,
)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also collate the external tensor files into one file for this model? Like what you are doing with the transformer.

@IlyasMoutawwakil
Copy link
Member

IlyasMoutawwakil commented Oct 23, 2024

Hello, we have added SD3 and Flux support in huggingface/optimum#2073.
We also did a big refactoring of the diffusers integration in optimum before it, which made adding new pipelines extremely simple to implement and test. Don't hesitate to check it.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@github-actions github-actions bot removed the stale Issues that haven't received updates label Oct 24, 2024
@yiyixuxu
Copy link
Collaborator

closing this now because we don't need this PR anymore because it is already in Optimum

let me know if we still need it and I can re-open it!

@yiyixuxu yiyixuxu closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants