Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace gym with gymnasium #2034

Merged
merged 1 commit into from
May 23, 2023
Merged

Replace gym with gymnasium #2034

merged 1 commit into from
May 23, 2023

Conversation

Adaickalavan
Copy link
Member

  1. This pull request is a step towards replacing gym with gymnasium. Related issue Minimize core package dependencies #1981.

    • info returned by hiway-v1 in reset() and step() methods are unified.
    • Seed of hiway-v1 env can be retrieved through a new property seed.
    • Replaced instances of hiway-v0 and gym with hiway-v1 and gymnasium, respectively.
  2. The following are the remaining components which still use gym. They are to be removed or made optional in subsequent pull requests.

    • SMARTS/smarts/env/hiway_env.py
    • SMARTS/smarts/env/tests/test_hiway_env.py
    • SMARTS/smarts/env/gymnasium/wrappers/api_reversion.py
    • SMARTS/examples/rl/rllib
    • SMARTS/smarts/env/wrappers/gif_recorder.py
    • SMARTS/smarts/env/wrappers/record_video.py
    • SMARTS/smarts/env/wrappers/recorder_wrapper.py
    • SMARTS/zoo/evaluation/npc_ego_example.py
    • SMARTS/zoo/policies/cross-rl-agent
    • SMARTS/zoo/policies/rl-agent

Copy link
Collaborator

@Gamenot Gamenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am seeing that this is a step rather than a full replacement (it does not remove gym entirely.)

smarts/env/gymnasium/hiway_env_v1.py Show resolved Hide resolved
smarts/env/tests/test_social_agent.py Show resolved Hide resolved
@Adaickalavan Adaickalavan merged commit c46f762 into master May 23, 2023
@Adaickalavan Adaickalavan deleted the rm-gym-1 branch May 23, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants