Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-33039 Fix artifact download version of UI and Bundles test GH Actions #19319

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/bundleTest-thor.md
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ The steps in the workflow run on the specified operating system, with Ubuntu-22.
This step enables us to download the ready-to-install HPCC Platform's artifact built on the latest commit.
```yaml
- name: Download Package
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: ${{ inputs.asset-name }}
path: ${{ inputs.asset-name }}
Expand Down Expand Up @@ -457,4 +457,4 @@ If any logs, ZAP reports, or .trace files are generated, they are uploaded as ar
/home/runner/HPCCSystems-regression/log/*
/home/runner/HPCCSystems-regression/zap/*
if-no-files-found: ignore
```
```
2 changes: 1 addition & 1 deletion .github/workflows/bundleTest-thor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
sudo rm -rf /usr/local/lib/android

- name: Download Package
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: ${{ inputs.asset-name }}
path: ${{ inputs.asset-name }}
Expand Down
15 changes: 11 additions & 4 deletions .github/workflows/test-ui-gh_runner.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ jobs:
path: ${{ inputs.asset-name }}

- name: Download Support Files
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: ${{ inputs.asset-name }}-support-files
path: ${{ inputs.asset-name }}-support-files
Expand Down Expand Up @@ -146,8 +146,15 @@ jobs:
sudo update-alternatives --set javac /usr/lib/jvm/java-21-openjdk-amd64/bin/javac
export JAVA_HOME=/usr/lib/jvm/java-21-openjdk-amd64/bin/java
export PATH=$PATH:$JAVA_HOME/bin
wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb
sudo apt-get install -y ./google-chrome-stable_current_amd64.deb

# To-Do: Need to find a solution to install same version of chrome and chromedriver
# The chrome stable current is 128
#wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb
#sudo apt-get install -y ./google-chrome-stable_current_amd64.deb
sudo apt-get remove -y google-chrome-stable
wget http://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_126.0.6478.182-1_amd64.deb
sudo apt-get install -y --allow-downgrades ./google-chrome-stable_126.0.6478.182-1_amd64.deb

wget https://storage.googleapis.com/chrome-for-testing-public/126.0.6478.126/linux64/chromedriver-linux64.zip
unzip chromedriver-linux64.zip -d chromedriver
sudo mv chromedriver/chromedriver-linux64/chromedriver /usr/bin/chromedriver
Expand Down Expand Up @@ -185,7 +192,7 @@ jobs:
if: ${{ failure() || cancelled() || env.uploadArtifact == 'true' }}
uses: actions/upload-artifact@v4
with:
name: ${{ inputs.asset-name }}-ecl_watch_ui_tests
name: ${{ inputs.asset-name }}-ecl_watch_ui_tests_result
path: |
${{ inputs.asset-name }}-ecl_watch_ui_tests/*.log
/home/runner/HPCCSystems-regression/log/*.json
Expand Down
Loading