Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-33039 Fix artifact download version of UI and Bundles test GH Actions #19319

Closed

Conversation

AttilaVamos
Copy link
Contributor

@AttilaVamos AttilaVamos commented Nov 26, 2024

Changes:

.github/workflows/bundleTest-thor.md:
.github/workflows/bundleTest-thor.yml:

  • Change 'Download Package' 'uses: actions/download-artifact@v3' to 'v4'

.github/workflows/test-ui-gh_runner.yml:

  • Change 'Download Support Files' 'uses: actions/download-artifact@v3' to 'v4'

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

…tions

.github/workflows/bundleTest-thor.md:
.github/workflows/bundleTest-thor.yml:
- Change 'Download Package' 'uses: actions/download-artifact@v3' to 'v4'

.github/workflows/test-ui-gh_runner.yml:
- Change 'Download Support Files' 'uses: actions/download-artifact@v3' to 'v4'

Signed-off-by: Attila Vamos <[email protected]>
@AttilaVamos AttilaVamos force-pushed the HPCC-33039-fix-master branch from 4856caf to 27bf55b Compare November 26, 2024 17:12
Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-33039

Jirabot Action Result:
Workflow Transition To: Merge Pending
Updated PR

- Fix result upload artifact name. (It needs to be unique.)

Signed-off-by: Attila Vamos <[email protected]>
- Fix diverged chrome and chrome-driver versions

Signed-off-by: Attila Vamos <[email protected]>
- Another attempt to fix chrome and chromedriver mismatch

Signed-off-by: Attila Vamos <[email protected]>
- Add comment to describe the current solution

Signed-off-by: Attila Vamos <[email protected]>
@ghalliday
Copy link
Member

@AttilaVamos this looks like it still has a problem. Also, it will need to tackle an older version of the platform (probably 9.2.x, or whenever this was introduced).

@AttilaVamos
Copy link
Contributor Author

AttilaVamos commented Nov 28, 2024

@ghalliday Yes it still reports error, but that problem is not environment related. The test found a problem with ECL Watch itself. See HPCC-33041.
With older version. Those tests: Bundle and ECL Watch UI introduced in 9.6.x, so they are not exists in older (9.4.x and earlier) versions of Platform.
Correction: The Bundle test introduced into 9.8.x, but ECL-Watch UI test is exist for a couple of years (improved in 9.8.x as well).

I need to check the Artifact handling version in 9.8.x and 9.6.x and probably retarget this PR.

@AttilaVamos
Copy link
Contributor Author

Replaced with PR-19323/HPCC-33050 and PR-19322/HPCC-33049

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants