Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-32930 Capture and report start timings for activities derived from CInMemJoinBase #19261

Merged
merged 1 commit into from
Nov 11, 2024
Merged

HPCC-32930 Capture and report start timings for activities derived from CInMemJoinBase #19261

merged 1 commit into from
Nov 11, 2024

Conversation

shamser
Copy link
Contributor

@shamser shamser commented Nov 1, 2024 •
edited
Loading

Capture start timing for input activities started asynchronously by CInMemJoinBase.

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@shamser shamser requested a review from jakesmith November 1, 2024 15:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32930

Jirabot Action Result:
Workflow Transition To: Merge Pending
Updated PR

jakesmith
jakesmith requested changes Nov 5, 2024
View reviewed changes
Copy link
Member

@jakesmith jakesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shamser - a couple of issues

thorlcr/activities/lookupjoin/thlookupjoinslave.cpp
@@ -1449,7 +1449,10 @@ class CInMemJoinBase : public CSlaveActivity, public CAllOrLookupHelper<HELPER>,
{
try
{
startInput(0);
{
LookAheadTimer t(slaveTimerStats, timeActivities);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't necessarily look ahead time, startLeftInput() can be called synchronously:

        if (rhsStartedBefore && isRhsConstant()) // if this is the 2nd+ iteration and the RHS is constant, don't bother restarting right, it will not be used.
        {
            startLeftInput();
        }
        else
        {
            CAsyncCallStart asyncLeftStart(std::bind(&CInMemJoinBase::startLeftInput, this));

thorlcr/activities/lookupjoin/thlookupjoinslave.cpp Outdated
@@ -1565,6 +1568,7 @@ class CInMemJoinBase : public CSlaveActivity, public CAllOrLookupHelper<HELPER>,
CAsyncCallStart asyncLeftStart(std::bind(&CInMemJoinBase::startLeftInput, this));
try
{
ActivityTimer timer(slaveTimerStats, timeActivities);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be a head of start, so it includes the whole of start() time afaics.
and normally for convention only: "ActivityTimer s(slaveTimerStats, timeActivities);" i.e. 's' for start.

@shamser shamser requested a review from jakesmith November 7, 2024 10:42
jakesmith
jakesmith reviewed Nov 8, 2024
View reviewed changes
Copy link
Member

@jakesmith jakesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shamser - 1 minor comment that I think worth addressing before squashing.

thorlcr/activities/lookupjoin/thlookupjoinslave.cpp Outdated
@@ -1462,6 +1465,10 @@ class CInMemJoinBase : public CSlaveActivity, public CAllOrLookupHelper<HELPER>,
leftexception.setown(e);
}
}
void startLeftInputAsync()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: not needed, see comment on async (bind) call below

thorlcr/activities/lookupjoin/thlookupjoinslave.cpp Outdated
@@ -1565,10 +1573,9 @@ class CInMemJoinBase : public CSlaveActivity, public CAllOrLookupHelper<HELPER>,
}
else
{
CAsyncCallStart asyncLeftStart(std::bind(&CInMemJoinBase::startLeftInput, this));
CAsyncCallStart asyncLeftStart(std::bind(&CInMemJoinBase::startLeftInputAsync, this));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of introducing a new method, can pass (bind) the bool here:

            CAsyncCallStart asyncLeftStart(std::bind(&CInMemJoinBase::startLeftInput, this, true));

@shamser
HPCC-32930 Capture and report start timings for activities derived fr…
898099a 
…om CInMemJoinBase

Capture start timing for input activities started asynchronously by CInMemJoinBase.

Signed-off-by: Shamser Ahmed <[email protected]>
@shamser shamser requested a review from jakesmith November 11, 2024 10:19
@shamser shamser mentioned this pull request Nov 11, 2024
Merged
39 tasks
jakesmith
jakesmith approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@jakesmith jakesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shamser - looks good.

@ghalliday ghalliday merged commit 69a550d into hpcc-systems:master Nov 11, 2024
53 checks passed
@github-actions GitHub Actions
Copy link

Jirabot Action Result:
Added fix version: 9.10.0
Workflow Transition: 'Resolve issue'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakesmith jakesmith jakesmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shamser @jakesmith @ghalliday