Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-32922 Capture lookahead timings for join and keyedjoin activities #19255

Merged
merged 1 commit into from
Nov 18, 2024
Merged

HPCC-32922 Capture lookahead timings for join and keyedjoin activities #19255

merged 1 commit into from
Nov 18, 2024

Conversation

shamser
Copy link
Contributor

@shamser shamser commented Oct 31, 2024 •
edited
Loading

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@github-actions GitHub Actions
Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32922

Jirabot Action Result:
Workflow Transition To: Merge Pending
Updated PR

@shamser shamser requested a review from jakesmith October 31, 2024 16:39
@shamser shamser force-pushed the issue32922 branch 2 times, most recently from cfedbed to 888ad90 Compare November 1, 2024 16:17
jakesmith
jakesmith requested changes Nov 5, 2024
View reviewed changes
Copy link
Member

@jakesmith jakesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shamser - please see comments.

thorlcr/activities/keyedjoin/thkeyedjoinslave.cpp Outdated
@@ -2662,6 +2662,7 @@ class CKeyedJoinSlave : public CSlaveActivity, implements IJoinProcessor, implem
}
void readAhead()
{
LookAheadTimer t(slaveTimerStats, timeActivities);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this means it will only update at the very end of reading the whole LHS input.
Perhaps should do every rows, it should call a t.commitTime() - that updates and reset startTime to current.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But also, I'm not sure that what it's considering as lookahead time is correct here (not just the time it spend reading from the input). Is it right?
As it stands, it's going to consider the input read time + the rest of the logica here in readAhead (e.g. the matching, lookup etc.), so totalCycles + lookAheadCycles - inputCycles, could leave local cycles looking too big,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm putting the lookahead around just the two inputStream->nextRow calls. That should mean that the tracking is more frequent and it should exclude the time for the other logic.

thorlcr/activities/lookupjoin/thlookupjoinslave.cpp Outdated
@@ -1447,6 +1447,7 @@ class CInMemJoinBase : public CSlaveActivity, public CAllOrLookupHelper<HELPER>,
IBitSet *queryRhsChannelStopSet() { dbgassertex(0 == queryJobChannelNumber()); return rhsChannelStop; }
void startLeftInput()
{
LookAheadTimer t(slaveTimerStats, timeActivities);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not around the startInput(0) ?

Copy link
Contributor Author

@shamser shamser Nov 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes related to lookahead in thlookupjoinslave.cpp is being done in #19261. This change is removed from this PR.

jakesmith
jakesmith reviewed Nov 5, 2024
View reviewed changes
thorlcr/activities/lookupjoin/thlookupjoinslave.cpp Outdated
@@ -1565,6 +1566,7 @@ class CInMemJoinBase : public CSlaveActivity, public CAllOrLookupHelper<HELPER>,
CAsyncCallStart asyncLeftStart(std::bind(&CInMemJoinBase::startLeftInput, this));
try
{
ActivityTimer s(slaveTimerStats, timeActivities);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I've missed something I think this should move to head of this start() function.

Copy link
Contributor Author

@shamser shamser Nov 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes related to lookahead in thlookupjoinslave.cpp is being done in #19261. This change is removed from this PR.

@shamser shamser force-pushed the issue32922 branch 2 times, most recently from d8e637f to cea98b2 Compare November 11, 2024 10:45
@shamser shamser requested a review from jakesmith November 11, 2024 11:12
jakesmith
jakesmith approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@jakesmith jakesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shamser - looks good. Please update the commit, PR and JIRA message to indicate that it is related to join and keyedjoin only.

Please go ahead and squash.

@shamser shamser changed the title HPCC-32922 Capture lookahead timings for join activities HPCC-32922 Capture lookahead timings for join and keyedjoin activities Nov 12, 2024
@shamser
Copy link
Contributor Author

shamser commented Nov 12, 2024

@jakesmith Squashed.

@ghalliday ghalliday merged commit ccdd99c into hpcc-systems:master Nov 18, 2024
50 checks passed
@github-actions GitHub Actions
Copy link

Jirabot Action Result:
Added fix version: 9.10.0
Workflow Transition: 'Resolve issue'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakesmith jakesmith jakesmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shamser @jakesmith @ghalliday