Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-31025 Add support for multiple trace exporters #18149

Merged
merged 3 commits into from
Jan 9, 2024
Merged

HPCC-31025 Add support for multiple trace exporters #18149

merged 3 commits into from
Jan 9, 2024

Conversation

ghalliday
Copy link
Member

@ghalliday ghalliday commented Dec 15, 2023 •
edited
Loading

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@ghalliday ghalliday requested a review from rpastrana December 15, 2023 15:52
@github-actions GitHub Actions
Copy link

https://track.hpccsystems.com/browse/HPCC-30125
Jira updated

@ghalliday
Copy link
Member Author

@rpastrana I realised I didn't update the schema or readme to include "exporters". I will do that later.

@ghalliday ghalliday changed the title HPCC-30125 Add support for multiple trace exporters HPCC-31025 Add support for multiple trace exporters Dec 15, 2023
@ghalliday ghalliday closed this Dec 15, 2023
@ghalliday ghalliday reopened this Dec 15, 2023
@github-actions GitHub Actions
Copy link

https://track.hpccsystems.com/browse/HPCC-31025
Jira updated

@ghalliday
Copy link
Member Author

I tested by adding a jlog exporter twice. Would probably benefit form more testing.

@ghalliday
Copy link
Member Author

ghalliday commented Dec 15, 2023 •
edited
Loading

Another problem is that exporter: type=none should suppress the creation of the jlog exporter. Actually this needs a little more discussion.

@ghalliday
Copy link
Member Author

see notes on implementation in the jida

rpastrana
rpastrana reviewed Dec 15, 2023
View reviewed changes
helm/hpcc/values.schema.json Outdated
},
"batch": {
"type": "boolean",
"description": "If true, trace data is processed in a batch, if false when it is available"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, but the last part doesn't make sense to me: ", if false when it is available"

@ghalliday ghalliday requested a review from rpastrana December 19, 2023 10:04
rpastrana
rpastrana reviewed Dec 20, 2023
View reviewed changes
system/jlib/jtrace.cpp
{
//Groups several spans together, before sending them to an exporter.
//MORE: These options should be configurable from batch/@option
opentelemetry::v1::sdk::trace::BatchSpanProcessorOptions options; //size_t max_queue_size = 2048;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://track.hpccsystems.com/browse/HPCC-31040

rpastrana
rpastrana reviewed Dec 20, 2023
View reviewed changes
Copy link
Member

@rpastrana rpastrana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghalliday looks good.
I'm not crazy about the config option name "createDefaultLogExporter" from the config point of view it should be more along the lines of "EnableDefaultLogExporter". subtle difference but I felt it was worth mentioning.
Also, there's a few sample config values files in helm/examples/tracing that would need to be updated, perhaps replaced:

@ghalliday ghalliday requested a review from rpastrana January 3, 2024 14:38
@ghalliday
Copy link
Member Author

@rpastrana I think I have addressed your comments, and resolved the clashes with your GRPC PR which I merged.

rpastrana
rpastrana approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@rpastrana rpastrana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghalliday looks good.

@ghalliday ghalliday merged commit 6f2198d into hpcc-systems:candidate-9.4.x Jan 9, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpastrana rpastrana rpastrana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghalliday @rpastrana