HPCC-30125 Add support for multiple trace exporters

Signed-off-by: Gavin Halliday <[email protected]>
hpcc-systems · Dec 15, 2023 · 316a1b3 · 316a1b3
1 parent d6e08bb
commit 316a1b3
Show file tree

Hide file tree

Showing 3 changed files with 163 additions and 159 deletions.
diff --git a/helm/examples/tracing/README.md b/helm/examples/tracing/README.md
@@ -13,24 +13,23 @@ All configuration options detailed here are part of the HPCC Systems Helm chart,
 - optAlwaysCreateTraceIds - If true components generate trace/span ids if none are provided by the remote caller.
 - exporter - Defines The type of exporter in charge of forwarding span data to target back-end
   - type - (default: JLOG) "OTLP-HTTP" | "OTLP-GRCP" | "OS" | "JLOG" | "NONE"
-  - JLOG
-    - logSpanDetails - Log span details such as description, status, kind
-    - logParentInfo  - Log the span's parent info such as ParentSpanId, and TraceState
-    - logAttributes  - Log the span's attributes
-    - logEvents      - Log the span's events
-    - logLinks       - Log the span's links
-    - logResources   - Log the span's resources such as telemetry.sdk version, name, language
-  - OTLP-HTTP
-    - endpoint - (default localhost:4318) Specifies the target OTLP-HTTP backend
-    - timeOutSecs - (default 10secs)
-    - consoleDebug - (default false)
-  - OTLP-GRCP
-    - endpoint: (default localhost:4317) The endpoint to export to. By default the OpenTelemetry Collector's default endpoint.
-    - useSslCredentials - By default when false, uses grpc::InsecureChannelCredentials; If true uses sslCredentialsCACertPath
-    - sslCredentialsCACertPath - Path to .pem file to be used for SSL encryption.
-    - timeOutSeconds - (default 10secs) Timeout for grpc deadline
-- processor - Controls span processing style. One by one as available, or in batches.
-  - type - (default: simple) "simple" | "batch"
+    - JLOG
+      - logSpanDetails - Log span details such as description, status, kind
+      - logParentInfo  - Log the span's parent info such as ParentSpanId, and TraceState
+      - logAttributes  - Log the span's attributes
+      - logEvents      - Log the span's events
+      - logLinks       - Log the span's links
+      - logResources   - Log the span's resources such as telemetry.sdk version, name, language
+    - OTLP-HTTP
+      - endpoint - (default localhost:4318) Specifies the target OTLP-HTTP backend
+      - timeOutSecs - (default 10secs)
+      - consoleDebug - (default false)
+    - OTLP-GRCP
+      - endpoint: (default localhost:4317) The endpoint to export to. By default the OpenTelemetry Collector's default endpoint.
+      - useSslCredentials - By default when false, uses grpc::InsecureChannelCredentials; If true uses sslCredentialsCACertPath
+      - sslCredentialsCACertPath - Path to .pem file to be used for SSL encryption.
+      - timeOutSeconds - (default 10secs) Timeout for grpc deadline
+  - batch - If true, trace data is processed in a batch, if false when it is available (simple)
 
 ### Sample configuration
 Below is a sample helm values block directing the HPCC tracing framework to process span information serially, and export the data over OTLP/HTTP protocol to localhost:4318 and output export debug information to console:
@@ -41,8 +40,6 @@ global:
     exporter:
       type: OTLP-HTTP
       consoleDebug: true
-    processor:
-      type: simple
 ```
 ### Sample configuration command
 

diff --git a/helm/hpcc/values.schema.json b/helm/hpcc/values.schema.json
@@ -1123,16 +1123,10 @@
               "type": "string",
               "enum": ["OTLP-HTTP", "OTLP-GRCP", "OS", "JLOG", "NONE"],
               "description": "The type of exporter in charge of forwarding span data to target back-end"
-            }
-          }
-        },
-        "processor": {
-          "type": "object",
-          "properties": {
-            "type": {
-              "type": "string",
-              "enum": ["batch", "simple"],
-              "description": "Defines the manner in which trace data is processed - in batches, or simple as available"
+            },
+            "batch": {
+              "type": "boolean",
+              "description": "If true, trace data is processed in a batch, if false when it is available"
             }
           }
         }