[Implemented]: Change Icon for 'Create Brokering Run' Button (#266) #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymaheshwari1
requested changes
Oct 22, 2024
…utline instead of arrowForwardOutline (hotwax#266) Reverted the incorrect icon change and updated the 'Create Brokering Run' button to use the correct 'addOutline' icon as per the issue requirements.
|
Hi @ymaheshwari1, Thanks for pointing that out! I’ve now fixed the issue by changing the icon of the "Create Brokering Run" button from arrowForwardOutline to addOutline as required. Please have a look and let me know if anything else needs adjustment. |
|
@coolnj4 You can remove the arrowForwardOutline from import, if thats not used anywhere in the code. |
|
Hi @ymaheshwari1, I’ve removed the unused import of arrowForwardOutline as well. Please have a look and let me know if anything else needs adjustment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the arrow icon (->) for the 'Create Brokering Run' button in the Order Routing app's Brokering Run page to a '+' icon.
Related Issues
Change Icon for "Create Brokering Run" Button #266
Contribution and Currently Important Rules Acceptance