Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Icon for "Create Brokering Run" Button #266

Closed
Adameddy26 opened this issue Oct 3, 2024 · 3 comments
Closed

Change Icon for "Create Brokering Run" Button #266

Adameddy26 opened this issue Oct 3, 2024 · 3 comments
Assignees
@Adameddy26
Labels
enhancement New feature or request hacktoberfest Good issue for Hacktoberfest event release-1.7.0

Comments

@Adameddy26
Copy link

Description

Currently, the "Create Brokering Run" button on the Order Routing app's Brokering Run page displays an arrow icon (->). This enhancement proposes changing the icon to a '+' icon for better clarity and alignment with user expectations.
@Adameddy26 Adameddy26 added the enhancement New feature or request label Oct 3, 2024
@Adameddy26 Adameddy26 added the hacktoberfest Good issue for Hacktoberfest event label Oct 3, 2024
@Adameddy26 Adameddy26 mentioned this issue Oct 3, 2024
Closed
@Adameddy26
Copy link
Author

Related issue : #233

coolnj4 added a commit to coolnj4/order-routing that referenced this issue Oct 20, 2024
@coolnj4
[Implemented]: Change Icon for 'Create Brokering Run' Button (hotwax#266
5467b96 
)

Changed the arrow icon (->) for the 'Create Brokering Run' button in the Order Routing app's Brokering Run page to a '+' icon.
@coolnj4 coolnj4 mentioned this issue Oct 20, 2024
Merged
1 task
@coolnj4
Copy link
Contributor

coolnj4 commented Oct 21, 2024

I’ve fixed the issue in PR #275 where I changed the arrow icon (->) for the "Create Brokering Run" button to a '+' icon. This update improves clarity and aligns with user expectations, as suggested.

Please review the changes and let me know if any further adjustments are needed!

coolnj4 added a commit to coolnj4/order-routing that referenced this issue Oct 22, 2024
@coolnj4
[Fixed]: Corrected icon for 'Create Brokering Run' button to use addO…
43bc35e 
…utline instead of arrowForwardOutline (hotwax#266)

Reverted the incorrect icon change and updated the 'Create Brokering Run' button to use the correct 'addOutline' icon as per the issue requirements.
ymaheshwari1 added a commit that referenced this issue Oct 22, 2024
@ymaheshwari1
Merge pull request #275 from coolnj4/main
89c281a 
[Implemented]: Change Icon for 'Create Brokering Run' Button (#266)
@ymaheshwari1 ymaheshwari1 moved this from 📋 Backlog to ⏸️ Dev complete in Digital Experience Platform Oct 22, 2024
@Adameddy26 Adameddy26 self-assigned this Nov 19, 2024
@Adameddy26 Adameddy26 moved this from ⏸️ Dev complete to 🛠 In QA in Digital Experience Platform Nov 19, 2024
@Adameddy26
Copy link
Author

Changes verified and working fine in release v1.7.0. Hence, closing this issue.

@github-project-automation github-project-automation bot moved this from 🛠 In QA to ✅ Done in Digital Experience Platform Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adameddy26 Adameddy26

Labels
enhancement New feature or request hacktoberfest Good issue for Hacktoberfest event release-1.7.0
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coolnj4 @Adameddy26