-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fr.json #1705
Update fr.json #1705
Conversation
Add or Update translations on the following added or modified strings: ADDED: child_bridge.label_child_start child_bridge.label_child_stop menu.hbrestart.confirm_button menu.hbrestart.confirmation menu.hbrestart.title menu.linux.label_logs plugins.button_api_documentation plugins.button_homepage plugins.manage.child_bridge_button_restart_now plugins.manage.child_bridge_button_restart_now_one plugins.manage.child_bridge_restart_success plugins.manage.child_bridge_restart_failed plugins.manage.message_thanks_for_updating_restart_child_bridges plugins.manage.modal_verified_cta plugins.manage.modal_verified_message plugins.manage.modal_verified_title plugins.node_update_homebridge_ui_upgrade_and_try_again status.widget.systeminfo.label_disabled status.widget.systeminfo.label_enabled status.widget.systeminfo.label_glibc_warning status.widget.systeminfo.label_no status.widget.systeminfo.label_nodejs_path status.widget.systeminfo.label_yes status.widget.systeminfo.modal_glibc_cta status.widget.systeminfo.modal_glibc_message status.widget.systeminfo.modal_glibc_title status.widget.systeminfo.modal_servicemode_cta status.widget.systeminfo.modal_servicemode_message status.widget.systeminfo.modal_servicemode_title UPDATED: plugins.manage.message_thanks_for_updating_restart plugins.donate.message_learn_more status.message_code_scan_instructions One inaccurate translation was also modified
@SonnyT72 Can you resolve conflicts? |
I would like to but it looks like I can't because I don't have write acces on this repo. |
What should be accepted? I am guessing patch-3? Also looks like you may have 1 more line that needs updating.
New line:
|
I don't understand what happened, maybe is it because I should have translated the latest available l18n file in the beta branch instead of the latest branch? Can you please confirm? Anyway, here are the correct translations (missing line) :
For the other translations, those in patch-3 are correct. Sorry :/ |
Yeah I would always look for a beta branch in the future, first then go to latest. We will always try to merge to latest first to publish a beta to verify all is well first then push out a release. |
Sorry, a few more conflicts:
So this line was added in the beta:
|
I have resolved the conflicts, but you should verify all looks good and update that other new line. |
Thanks @SonnyT72 |
Add or Update translations on the following added or modified strings:
ADDED:
child_bridge.label_child_start
child_bridge.label_child_stop
menu.hbrestart.confirm_button
menu.hbrestart.confirmation
menu.hbrestart.title
menu.linux.label_logs
plugins.button_api_documentation
plugins.button_homepage
plugins.manage.child_bridge_button_restart_now
plugins.manage.child_bridge_button_restart_now_one
plugins.manage.child_bridge_restart_success
plugins.manage.child_bridge_restart_failed
plugins.manage.message_thanks_for_updating_restart_child_bridges
plugins.manage.modal_verified_cta
plugins.manage.modal_verified_message
plugins.manage.modal_verified_title
plugins.node_update_homebridge_ui_upgrade_and_try_again
status.widget.systeminfo.label_disabled
status.widget.systeminfo.label_enabled
status.widget.systeminfo.label_glibc_warning
status.widget.systeminfo.label_no
status.widget.systeminfo.label_nodejs_path
status.widget.systeminfo.label_yes
status.widget.systeminfo.modal_glibc_cta
status.widget.systeminfo.modal_glibc_message
status.widget.systeminfo.modal_glibc_title
status.widget.systeminfo.modal_servicemode_cta
status.widget.systeminfo.modal_servicemode_message
status.widget.systeminfo.modal_servicemode_title
UPDATED:
plugins.manage.message_thanks_for_updating_restart
plugins.donate.message_learn_more
status.message_code_scan_instructions
One inaccurate translation was also modified
♻️ Current situation
Describe the current situation. Explain current problems, if there are any. Be as descriptive as possible (e.g., including examples or code snippets).
💡 Proposed solution
Describe the proposed solution and changes. How does it affect the project? How does it affect the internal structure (e.g., refactorings)?
⚙️ Release Notes
Provide a summary of the changes or features from a user's point of view. If there are breaking changes, provide migration guides using code examples of the affected features.
➕ Additional Information
If applicable, provide additional context in this section.
Testing
Which tests were added? Which existing tests were adapted/changed? Which situations are covered, and what edge cases are missing?
Reviewer Nudging
Where should the reviewer start? what is a good entry point?