Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed the bug on email validation #924

Merged
merged 5 commits into from
Aug 22, 2024

Conversation

johnson-oragui
Copy link
Collaborator

This Pull Request is intended to correct the bug that allows users to use an invalid email(non-existing domain part) for registration, login, request-magic-link, and reset-password.

Description

This Pull Request is intended to correct the bug that allows users to use an invalid email(non-existing domain part) for registration, login, request-magic-link, and reset-password.
Prior to this PR, users were able to register, login with an invalid email like [email protected] or [email protected], but with this fix, the email validation on these four endpoints mentioned above are now properly validated.

Related Issue (Link to issue ticket)

Invalid email on login

Invalid email on registration

invalid email on password reset

invalid email on magic-link

Motivation and Context

How Has This Been Tested?

This has been tested with pytest and postman.

Screenshots (if appropriate - Postman, etc):


bugfix email  com com

bugfix email

bugfix example come login

bugfix login

bugfix pytests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@johnson-oragui
Copy link
Collaborator Author

@trevorjob

Kindly reviews

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment