Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Invalid domain part allowed in email during Login #919

Open
johnson-oragui opened this issue Aug 21, 2024 · 0 comments · Fixed by #924
Open

[FIX] Invalid domain part allowed in email during Login #919

johnson-oragui opened this issue Aug 21, 2024 · 0 comments · Fixed by #924
Assignees

Comments

@johnson-oragui
Copy link
Collaborator

Describe the bug
During the process of logging in for a user, the domain part of email is not properly validated, especially after the [.com, .tech, .net] part of the domain part. Users can login without email validated.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://staging.api-python.boilerplate.hng.tech/login'
  2. Enter email '[email protected]'
  3. Enter password 'Johnson1234#'
  4. Click on login
  5. See bug: User logs in successfully

Expected behavior
The backend should respond with an appropriate error message like "Invalid email domain part"

Screenshots
If applicable, add screenshots to help explain your problem.
ENTER INVALID EMAIL DURING LOGIN
bug login

INVALID EMAIL ALLOWED DURING LOGIN
bug login allow invalid email

Desktop (please complete the following information):

  • Browser brave
  • Version 22

Additional context
The invalid email should not be allowed for login, even if it was allowed during registration, the login data fields validation should be independent of the registration field validation.

@johnson-oragui johnson-oragui self-assigned this Aug 21, 2024
@johnson-oragui johnson-oragui linked a pull request Aug 22, 2024 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant