Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments schema fix #8794

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Comments schema fix #8794

merged 2 commits into from
Aug 8, 2024

Conversation

timolegros
Copy link
Collaborator

@timolegros timolegros commented Aug 7, 2024

Link to Issue

Closes: #8792

Description of Changes

For some reason, on a users first comment, canvas hash/sigs are null when they shouldn't be. The fix for now is to make these properties nullish in the schema like in the other existing schemas.

Test Plan

  • Deploy and test notifications on QA (where canvas is enabled)

Deployment Plan

Other Considerations

  • Forwarded canvas hash null issue on first post to @raykyri

@ilijabojanovic ilijabojanovic self-requested a review August 8, 2024 13:29
@ilijabojanovic ilijabojanovic merged commit b2d48f0 into master Aug 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid Event Schema on first notification
3 participants