Merge pull request #8794 from hicommonwealth/tim/fix-comments-schema

Comments schema fix
hicommonwealth · Aug 8, 2024 · b2d48f0 · b2d48f0
2 parents 29d3c73 + bad42cf
commit b2d48f0
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 6 deletions.
diff --git a/libs/schemas/src/entities/comment.schemas.ts b/libs/schemas/src/entities/comment.schemas.ts
@@ -13,8 +13,8 @@ export const Comment = z.object({
   version_history: z.array(z.string()).optional(),
   version_history_updated: z.boolean().optional(),
 
-  canvas_signed_data: z.string(),
-  canvas_hash: z.string(),
+  canvas_signed_data: z.string().nullish(),
+  canvas_hash: z.string().nullish(),
 
   created_by: z.string().nullish(),
   created_at: zDate.nullish(),

diff --git a/packages/commonwealth/server/controllers/server_threads_methods/create_thread_comment.ts b/packages/commonwealth/server/controllers/server_threads_methods/create_thread_comment.ts
@@ -171,9 +171,7 @@ export async function __createThreadComment(
     address_id: address.id,
     community_id: thread.community_id,
     parent_id: null,
-    // @ts-expect-error <StrictNullChecks>
     canvas_signed_data: canvasSignedData,
-    // @ts-expect-error <StrictNullChecks>
     canvas_hash: canvasHash,
     discord_meta: discordMeta,
     reaction_count: 0,

diff --git a/packages/commonwealth/server/util/sanitizeDeletedComment.ts b/packages/commonwealth/server/util/sanitizeDeletedComment.ts
@@ -17,9 +17,7 @@ export function sanitizeDeletedComment(
       is_user_default: false,
     },
     address_id: 0,
-    // @ts-expect-error <StrictNullChecks>
     canvas_hash: null,
-    // @ts-expect-error <StrictNullChecks>
     canvas_signed_data: null,
     plaintext: '[deleted]',
     text: '[deleted]',