Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fix #8788

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Bug Fix #8788

merged 3 commits into from
Aug 7, 2024

Conversation

timolegros
Copy link
Collaborator

Link to Issue

Closes: #8787

Description of Changes

Test Plan

  • Start local server
  • go to localhost and copy JWT from any authenticated request
  • Run pnpm set-super-admin false
curl -X DELETE http://localhost:8080/api/topics/63 -H "Content-Type: application/json" -d '{"jwt": "[past JWT here]"}'

The request should fail. Feel free to try with any topic id.

Deployment Plan

Other Considerations

@timolegros timolegros requested a review from Rotorsoft August 7, 2024 18:46
@timolegros timolegros requested review from rbennettcw, jnaviask and kurtisassad and removed request for rbennettcw August 7, 2024 18:46
@jnaviask jnaviask merged commit 3be8ea7 into master Aug 7, 2024
9 checks passed
@jnaviask jnaviask deleted the tim/topics-fix branch August 7, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbennettcw rbennettcw rbennettcw approved these changes

@Rotorsoft Rotorsoft Rotorsoft approved these changes

@jnaviask jnaviask jnaviask approved these changes

@kurtisassad kurtisassad Awaiting requested review from kurtisassad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug
4 participants
@timolegros @jnaviask @Rotorsoft @rbennettcw