Merge pull request #8788 from hicommonwealth/tim/topics-fix

Bug Fix
hicommonwealth · Aug 7, 2024 · 3be8ea7 · 3be8ea7
2 parents 89e556e + bf6ad62
commit 3be8ea7
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/packages/commonwealth/server/controllers/server_topics_methods/create_topic.ts b/packages/commonwealth/server/controllers/server_topics_methods/create_topic.ts
@@ -56,7 +56,7 @@ export async function __createTopic(
     true,
   );
 
-  const isAdmin = validateOwner({
+  const isAdmin = await validateOwner({
     models: this.models,
     user,
     // @ts-expect-error StrictNullChecks

diff --git a/packages/commonwealth/server/controllers/server_topics_methods/delete_topic.ts b/packages/commonwealth/server/controllers/server_topics_methods/delete_topic.ts
@@ -27,7 +27,7 @@ export async function __deleteTopic(
     throw new AppError(Errors.TopicNotFound);
   }
 
-  const isAdmin = validateOwner({
+  const isAdmin = await validateOwner({
     models: this.models,
     user,
     communityId: topic.community_id,

diff --git a/packages/commonwealth/test/unit/server_controllers/server_topics_controller.spec.ts b/packages/commonwealth/test/unit/server_controllers/server_topics_controller.spec.ts
@@ -78,7 +78,7 @@ const createMockedTopicsController = (isAdmin: boolean = false) => {
 
 describe('ServerTopicsController', () => {
   test('#createTopic', async () => {
-    const { controller, user, chain } = createMockedTopicsController();
+    const { controller, user, chain } = createMockedTopicsController(true);
     const [topic] = await Promise.all(
       await controller.createTopic({
         user,
@@ -99,7 +99,7 @@ describe('ServerTopicsController', () => {
   });
 
   test('#deleteTopic', async () => {
-    const { controller, user } = createMockedTopicsController();
+    const { controller, user } = createMockedTopicsController(true);
     await controller.deleteTopic({
       user,
       topicId: 1,