Add a Salesforce Functions builder variant #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
force-pushed
the
edmorley/salesforce-functions-variant
branch
2 times, most recently
from
93dcbd3 to
c57e7c6
Compare
edmorley
commented
Sep 25, 2023
|
Note to self: When this is ready to be merged, also adjust the required status checks in the branch protection settings. |
edmorley
force-pushed
the
edmorley/salesforce-functions-variant
branch
from
c57e7c6 to
5cb210f
Compare
edmorley
changed the title
edmorley
force-pushed
the
edmorley/salesforce-functions-variant
branch
2 times, most recently
from
fc6611f to
d672692
Compare
Malax
approved these changes
Sep 26, 2023
We want to move Salesforce Functions buildpacks to their own builder image variant to more cleanly separate the two use cases (particularly given that Salesforce Functions is now deprecated), and prevent a number of issues (such as builds on the functions build system being able to pass detection even when the match against a non-functions buildpack). For more details, see: https://salesforce.quip.com/MoDFAX3MEf8b The first stage of this is to create the new builder image variant. This new variant is only being published to the internal private registry, since it's only being used by Kodon (the SF CLI no longer supports using containers to run functions). Once it's released, we can then switch Kodon to using the new tag, deploy Kodon to all functions instances, and then finally remove the functions buildpacks from `heroku/builder:22`. We'll also need to adjust the CNB release automation so that it updates the new image variant too: https://github.com/heroku/languages-github-actions/blob/8f1d3319996df5ec9eb3b4c9c7c0d5de78fa9dba/.github/workflows/_buildpacks-release.yml#L315 GUS-W-14179967.
edmorley
force-pushed
the
edmorley/salesforce-functions-variant
branch
from
d672692 to
385deaf
Compare
|
Branch protection list of required CI checks updated. |
edmorley
added a commit
to heroku/languages-github-actions
that referenced
this pull request
Sep 26, 2023
) Adds the two new builder image variants recently added to the `heroku/builder` repo: - heroku/cnb-builder-images#392 - heroku/cnb-builder-images#394 GUS-W-14185090.
edmorley
added a commit
that referenced
this pull request
Oct 2, 2023
A new functions only builder image variant was added in #392 (see that PR for why), and now the functions Kodon instances have been switched to use this new image in: heroku/kodon#408 As such, the functions buildpacks in `heroku/builder:22` are now unused and can be removed. In addition, the functions examples have been moved under the functions builder's directory, since its now the only builder using them. GUS-W-14194543.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to move Salesforce Functions buildpacks to their own builder image variant to more cleanly separate the two use cases (particularly given that Salesforce Functions is now deprecated), and prevent a number of issues (such as builds on the functions build system being able to pass detection even when the match against a non-functions buildpack).
For more details, see:
https://salesforce.quip.com/MoDFAX3MEf8b
The first stage of this is to create the new builder image variant.
This new variant is only being published to the internal private registry, since it's only being used by Kodon (the SF CLI no longer supports using containers to run functions) so doesn't need to be available on Docker Hub.
Once it's released, we can then switch Kodon to using the new tag, deploy Kodon to all functions spaces, and then finally remove the functions buildpacks from
heroku/builder:22.We'll also need to adjust the CNB release automation so that it updates the new image variant too:
https://github.com/heroku/languages-github-actions/blob/8f1d3319996df5ec9eb3b4c9c7c0d5de78fa9dba/.github/workflows/_buildpacks-release.yml#L315
GUS-W-14179967.