Remove functions buildpacks from heroku/builder:22
#398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new functions only builder image variant was added in #392 (see that PR for why), and now the functions Kodon instances have been switched to use this new image in: heroku/kodon#408 As such, the functions buildpacks in `heroku/builder:22` are now unused and can be removed. In addition, the functions examples have been moved under the functions builder's directory, since its now the only builder using them. GUS-W-14194543.
dzuelke
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new functions only builder image variant was added in #392 (see that PR for why), and now the functions Kodon instances have been switched to use this new image in:
https://github.com/heroku/kodon/pull/408
As such, the functions buildpacks in
heroku/builder:22are now unused and can be removed.In addition, the functions examples have been moved under the functions builder's directory, since it's now the only builder using them.
GUS-W-14194543.