Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apt - Minimum Viable Buildpack - 02 - Aptfile Parsing #2

Merged
merged 7 commits into from
Feb 21, 2024
Merged

Apt - Minimum Viable Buildpack - 02 - Aptfile Parsing #2

merged 7 commits into from
Feb 21, 2024

Conversation

colincasey
Copy link
Contributor

@colincasey colincasey commented Feb 9, 2024 •
edited
Loading

The Aptfile is how an application can specify custom packages to install. Unlike the version from our classic apt buildpack, this parser does not support:

Only package names, comment lines, and blank lines are supported in this version.

Package names are parsed according to the restrictions defined in the Debian Manual.

@colincasey colincasey added the skip changelog Skip the check-changelog check label Feb 9, 2024
@colincasey colincasey force-pushed the apt_mvbp/02-aptfile branch 3 times, most recently from 98a8291 to 4e13abe Compare February 12, 2024 14:14
This was referenced Feb 12, 2024
Merged
Closed
@colincasey colincasey added skip changelog Skip the check-changelog check and removed skip changelog Skip the check-changelog check labels Feb 14, 2024
Base automatically changed from apt_mvbp/01 to main February 15, 2024 18:29
@colincasey colincasey marked this pull request as ready for review February 15, 2024 18:39
@colincasey colincasey requested a review from a team as a code owner February 15, 2024 18:39
edmorley
edmorley requested changes Feb 16, 2024
View reviewed changes
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting to see rapid progress on this! :-D

src/main.rs Show resolved Hide resolved
src/errors.rs Outdated Show resolved Hide resolved
src/errors.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/aptfile.rs Outdated Show resolved Hide resolved
src/aptfile.rs Outdated Show resolved Hide resolved
src/aptfile.rs Outdated Show resolved Hide resolved
src/aptfile.rs Outdated Show resolved Hide resolved
src/aptfile.rs Show resolved Hide resolved
src/aptfile.rs Show resolved Hide resolved
@colincasey colincasey requested a review from edmorley February 16, 2024 20:01
edmorley
edmorley reviewed Feb 19, 2024
View reviewed changes
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes :-)

src/aptfile.rs Show resolved Hide resolved
src/aptfile.rs Outdated Show resolved Hide resolved
src/aptfile.rs Outdated Show resolved Hide resolved
tests/integration_test.rs Show resolved Hide resolved
tests/integration_test.rs Outdated Show resolved Hide resolved
@colincasey colincasey requested a review from edmorley February 20, 2024 14:24
edmorley
edmorley approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

tests/integration_test.rs Show resolved Hide resolved
@colincasey colincasey merged commit 6c91816 into main Feb 21, 2024
5 checks passed
@colincasey colincasey deleted the apt_mvbp/02-aptfile branch February 21, 2024 15:45
@colincasey colincasey mentioned this pull request Feb 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshwlewis joshwlewis joshwlewis approved these changes

@edmorley edmorley edmorley approved these changes

Assignees
No one assigned
Labels
skip changelog Skip the check-changelog check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colincasey @edmorley @joshwlewis