Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apt - Minimum Viable Buildpack - 01 - Project Structure #1

Merged
merged 6 commits into from
Feb 15, 2024

Conversation

colincasey
Copy link
Contributor

@colincasey colincasey commented Feb 9, 2024

This initial version of the Apt CNB closely follows the process laid down in heroku/heroku-buildpack-apt and has been split into the following stacked PRs:

Note

More details about each set of changes can be found in the individual PRs.

This PR sets up the basic template for our buildpack projects including:

  • Automation
    • CODEOWNERS
    • Dependabot Configuration
    • Workflows for continuous integration and release activities
  • Salesforce OpenSource Template Files
    • LICENSE.txt
    • CODE_OF_CONDUCT.md
    • SECURITY.md
    • CONTRIBUTING.md
  • Project Files
    • Cargo.toml
    • buildpack.toml
      • a placeholder buildpack structure in main.rs

@colincasey colincasey changed the title Apt - Minimum Viable Buildpack Apt - Minimum Viable Buildpack - 01 - Project Structure Feb 9, 2024
@colincasey colincasey requested a review from a team February 9, 2024 20:42
Copy link
Member

@joshwlewis joshwlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start!

@colincasey colincasey marked this pull request as ready for review February 14, 2024 19:59
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this! I'm super exited to (a) have a non-shimmed APT CNB, (b) have an APT buildpack that doesn't have the bugs of its classic buildpack predecessor :-)

.github/dependabot.yml Outdated Show resolved Hide resolved
.gitignore Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
buildpack.toml Show resolved Hide resolved
buildpack.toml Outdated Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
src/main.rs Show resolved Hide resolved
tests/integration_test.rs Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@colincasey colincasey requested a review from edmorley February 15, 2024 15:10
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes and the quick turnaround - makes re-reviewing fast since all still fresh in my head :-)

buildpack.toml Outdated Show resolved Hide resolved
buildpack.toml Outdated Show resolved Hide resolved
buildpack.toml Outdated Show resolved Hide resolved
buildpack.toml Outdated Show resolved Hide resolved
@colincasey colincasey merged commit b1bbec8 into main Feb 15, 2024
5 checks passed
@colincasey colincasey deleted the apt_mvbp/01 branch February 15, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants