Fixes #491 - mainUrl was not an absolute path #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Apr 11, 2023
| @@ -226,7 +226,7 @@ public function mainJS() | |||
| { | |||
| $version = new EmptyVersionStrategy(); | |||
| $package = new Package($version); | |||
| $mainUrl = $package->getUrl('bundles/fmelfinder/js'); | |||
| $mainUrl = $package->getUrl('/bundles/fmelfinder/js'); | |||
There was a problem hiding this comment.
I know this is already merged but shouldn't this code also contain the assets_path? see example config https://github.com/helios-ag/FMElfinderBundle#add-configuration-options-to-your-configyaml where we can define a asset path?
There was a problem hiding this comment.
I just confirmed for me when having assets_path set and chaning this line to:
$mainUrl = $package->getUrl(sprintf('%s/bundles/fmelfinder/js', $this->params['assets_path']));
I loads my assets file for elfinder again
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following issue #491, in ElFinderController, when defining $mainUrl at line 229, this is a relative path and not absolute.
To make it absolute, a / have been added according to the Symfony documentation.