Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The assets for elfinder.min.js are giving 404 when using a different asset_path #497

Closed
ghost opened this issue Apr 11, 2023 · 9 comments · Fixed by #509
Closed

The assets for elfinder.min.js are giving 404 when using a different asset_path #497

ghost opened this issue Apr 11, 2023 · 9 comments · Fixed by #509

Comments

@ghost
Copy link

ghost commented Apr 11, 2023

Describe the bug
I have my asset_path configured to a different folder now with the recent changes: #493 i breaks it probably was already broke before this fix. Some more context: https://github.com/helios-ag/FMElfinderBundle/pull/493/files#r1162540304

To Reproduce
Have a asset_path defined to different folder then the default and check you get 404 when loading the assets.

@ghost
Copy link
Author

ghost commented Apr 11, 2023

Also can confirm that /img/volume_icon_ftp.png is also not loading for me

@enboig
Copy link

enboig commented Sep 18, 2024

I am affected by this bug, when will it be merged and released?

@ghost
Copy link
Author

ghost commented Sep 18, 2024

The fix is in #509 but there is not much activity there atm.

For me i just locked my composer.json to older version for temporary fix to: "helios-ag/fm-elfinder-bundle": "12.2.1",

@enboig
Copy link

enboig commented Sep 18, 2024

I was thinking of using https://github.com/symplify/vendor-patches

@helios-ag
Copy link
Owner

I can merge it guys, but didn't test for back compatiblity, if someone confirms, ok, will proceed

helios-ag added a commit that referenced this issue Sep 19, 2024
Fixes #497 mainUrl didn't contain asset path
@JohJohan
Copy link
Contributor

I can confirm it works for me, but thats expected since i supplied the fix. When will we get a release?

@enboig maybe you can confirm it works for you?

@jontjs
Copy link
Contributor

jontjs commented Oct 7, 2024

This update appears to have broken elfinder for us (default assets path, and also still using Symfony 6.4 in case that's relevent). With version 12.5 of this bundle, the elfinder assets are loaded from bundles/fmelfinder/ (which matches where other bundles but their assets) but they are now loaded from assets/bundles/fmelfinder/.

I've got a feeling that the problem is that the default value of assets_path in the bundle config is "assets", is different to the default value of the docroot argument to the install command (which is blank).

As a workaround, you can either set the assets_path to an empty string in the bundle config, or run elfinder:install --docroot=public/assets to install the assets.

@JohJohan
Copy link
Contributor

JohJohan commented Oct 9, 2024

Ah sorry @jontjs it broke for you and probably others, i'm thinking changing the default assets_path to empty is also not an option as that could possible break other things i think.

@helios-ag
Copy link
Owner

@JohJohan @jontjs if you confirm we can make value empty by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants