Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontend: Enable allowProposedApi in XTerminal #2562

Merged
merged 1 commit into from
Nov 18, 2024
Merged

frontend: Enable allowProposedApi in XTerminal #2562

merged 1 commit into from
Nov 18, 2024

Conversation

veyselsahin
Copy link
Contributor

@veyselsahin veyselsahin commented Nov 12, 2024 •
edited by skoeva
Loading

Fixes: #2558

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 12, 2024
@veyselsahin veyselsahin force-pushed the allowproposeapi-xterm-option-added branch from eb9a661 to 5ac8f34 Compare November 12, 2024 23:11
@veyselsahin veyselsahin mentioned this pull request Nov 13, 2024
Closed
joaquimrocha
joaquimrocha requested changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@joaquimrocha joaquimrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @veyselsahin . Left a comment. Hope it helps.

frontend/src/components/common/LogViewer.tsx Outdated Show resolved Hide resolved
@veyselsahin veyselsahin force-pushed the allowproposeapi-xterm-option-added branch from 5ac8f34 to 128e93e Compare November 13, 2024 10:53
@veyselsahin
Copy link
Contributor Author

@joaquimrocha

reducers.tsx                                  |     100 |      100 |     100 |     100 |                                                                                                              
ui.tsx                                        |   42.85 |       40 |     100 |   42.85 | 38-57                                                                                                        
src/redux/stores                               |     100 |      100 |     100 |     100 |                                                                                                              
store.tsx                                     |     100 |      100 |     100 |     100 |                                                                                                              
src/stateless                                  |   15.34 |    12.34 |   17.39 |   15.13 |                                                                                                              
index.ts                                      |   15.34 |    12.34 |   17.39 |   15.13 | 94-204,239-257,269,305,323-568                                                                               
src/test                                       |   89.47 |    81.81 |      75 |   89.18 |                                                                                                              
index.tsx                                     |   81.25 |    78.94 |      50 |   81.25 | 47-50                                                                                                        
mocker.ts                                     |   95.45 |    85.71 |     100 |   95.23 | 51                                                                                                           
------------------------------------------------|---------|----------|---------|---------|--------------------------------------------------------------------------------------------------------------

PASS  Waiting for file changes...
     press h to show help, press q to quit

This is the output of the test command. I pressed h, u, and a again to make sure, but the output is the same.

@veyselsahin veyselsahin marked this pull request as draft November 13, 2024 11:17
@veyselsahin veyselsahin force-pushed the allowproposeapi-xterm-option-added branch from 2e44fa0 to a4d89b8 Compare November 13, 2024 11:30
@skoeva skoeva marked this pull request as ready for review November 13, 2024 13:59
@skoeva skoeva marked this pull request as draft November 13, 2024 13:59
@veyselsahin veyselsahin force-pushed the allowproposeapi-xterm-option-added branch from a4d89b8 to 5dc71a0 Compare November 13, 2024 14:11
@skoeva skoeva changed the title Enable allowProposedApi in XTerminal to fix Linux log search (#2558) frontend: Enable allowProposedApi in XTerminal Nov 15, 2024
@veyselsahin veyselsahin force-pushed the allowproposeapi-xterm-option-added branch from 63b3a4f to 5170661 Compare November 16, 2024 21:33
@veyselsahin veyselsahin marked this pull request as ready for review November 16, 2024 21:41
skoeva
skoeva approved these changes Nov 16, 2024
View reviewed changes
Copy link
Contributor

@skoeva skoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for contributing

@veyselsahin veyselsahin force-pushed the allowproposeapi-xterm-option-added branch from 5170661 to 2199709 Compare November 17, 2024 17:41
@veyselsahin veyselsahin force-pushed the allowproposeapi-xterm-option-added branch from 2199709 to e3fd7cb Compare November 17, 2024 17:51
@veyselsahin
Copy link
Contributor Author

waits for #2560 to be fixed

illume
illume approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks!

(Note, the test plugins CI job failure is unrelated to this PR).

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 18, 2024
@illume illume merged commit 8fb46f6 into headlamp-k8s:main Nov 18, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skoeva skoeva skoeva approved these changes

@illume illume illume approved these changes

@joaquimrocha joaquimrocha Awaiting requested review from joaquimrocha

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Searching doesn't work on linux
4 participants
@veyselsahin @illume @joaquimrocha @skoeva