Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontend: xterm missing allowProposedApi option added #2559

Closed
wants to merge 0 commits into from
Closed

frontend: xterm missing allowProposedApi option added #2559

wants to merge 0 commits into from

Conversation

veyselsahin
Copy link
Contributor

No description provided.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 11, 2024
@veyselsahin veyselsahin mentioned this pull request Nov 11, 2024
Closed
@veyselsahin
Copy link
Contributor Author

solves #2558

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Nov 11, 2024
@veyselsahin veyselsahin marked this pull request as draft November 11, 2024 09:16
@skoeva
Copy link
Contributor

skoeva commented Nov 11, 2024

Thanks for this! When you are ready to mark this for review, please don't forget to sign off the commit (you can do this using git commit -s or for an existing commit, use git commit -s --amend)

@veyselsahin veyselsahin marked this pull request as ready for review November 11, 2024 15:11
@skoeva
Copy link
Contributor

skoeva commented Nov 11, 2024

Solid, if you're done making changes then an atomic commit would be preferred (instructions here), and like before, sign it off using git commit -s

@skoeva skoeva linked an issue Nov 11, 2024 that may be closed by this pull request
Searching doesn't work on linux #2558
Closed
@skoeva skoeva added bug Something isn't working frontend Issues related to the frontend labels Nov 11, 2024
@veyselsahin veyselsahin force-pushed the allowproposeapi-xterm-option-added branch from e6b31b9 to 07ae9f5 Compare November 12, 2024 21:54
@veyselsahin veyselsahin force-pushed the allowproposeapi-xterm-option-added branch from bb0a68b to 21abddc Compare November 12, 2024 22:27
@veyselsahin veyselsahin deleted the allowproposeapi-xterm-option-added branch November 12, 2024 22:55
@skoeva
Copy link
Contributor

skoeva commented Nov 13, 2024

Did you run into git-related issues? Let us know if you would like to continue working on this issue

@veyselsahin
Copy link
Contributor Author

Hey @skoeva, please bear with me as I feel a bit rusty on git and the evolved contributing process:) I reset the head of the branch to deliver an atomic commit that hides my scratches. Here is the recently created PR after my reset #2562

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working frontend Issues related to the frontend size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Release Plan / Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Searching doesn't work on linux
2 participants
@veyselsahin @skoeva