Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set fixed values and column attrs on autogen class #800

Merged
merged 13 commits into from
Oct 26, 2023
Merged

Conversation

rly
Copy link
Contributor

@rly rly commented Dec 8, 2022

Motivation

Fix #798

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@rly rly added this to the Next Release milestone Jan 12, 2023
@rly rly marked this pull request as ready for review October 25, 2023 05:01
@rly rly requested a review from oruebel October 25, 2023 05:02
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (afd1882) 88.57% compared to head (1d68452) 88.59%.
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #800      +/-   ##
==========================================
+ Coverage   88.57%   88.59%   +0.01%     
==========================================
  Files          45       45              
  Lines        9400     9424      +24     
  Branches     2673     2684      +11     
==========================================
+ Hits         8326     8349      +23     
- Misses        759      760       +1     
  Partials      315      315              
Files Coverage Δ
src/hdmf/build/classgenerator.py 95.41% <100.00%> (+0.43%) ⬆️
src/hdmf/common/table.py 86.38% <100.00%> (+0.44%) ⬆️
src/hdmf/spec/spec.py 90.89% <100.00%> (+0.03%) ⬆️
src/hdmf/common/io/table.py 75.00% <85.71%> (-8.84%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly rly changed the title [WIP] Set fixed values on autogen class Set fixed values on autogen class Oct 25, 2023
@rly
Copy link
Contributor Author

rly commented Oct 25, 2023

This issue is blocking progress on the ndx-events extension and also I should have been finished it a long time ago...

@rly
Copy link
Contributor Author

rly commented Oct 25, 2023

Also fix #972.

@rly rly changed the title Set fixed values on autogen class Set fixed values and column attrs on autogen class Oct 25, 2023
@rly
Copy link
Contributor Author

rly commented Oct 25, 2023

Also fix #973 which uses related code.

@rly rly merged commit efced9e into dev Oct 26, 2023
26 checks passed
@rly rly deleted the fix/autoclass_fixed_value2 branch October 26, 2023 00:22
@rly rly removed this from the 3.14.0 milestone Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Handling of attributes with fixed value in get_class
2 participants