Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Autogen table class does not set column name attribute, breaking roundtrip #973

Closed
3 tasks done
rly opened this issue Oct 25, 2023 · 1 comment
Closed
3 tasks done

[Bug]: Autogen table class does not set column name attribute, breaking roundtrip #973

rly opened this issue Oct 25, 2023 · 1 comment

Comments

@rly
Copy link
Contributor

rly commented Oct 25, 2023

What happened?

When an extension SubTable extends DynamicTable and get_class is used to auto-generate an API class, any columns defined in the SubTable extension, e.g., a VectorData with name "timestamp", should be set in both the columns tuple attribute on SubTable and using the name of the column, e.g., SubTable.timestamp. This is necessary for get_attr_value to work during building of the table when it is written to disk.

Steps to Reproduce

n/a

Traceback

No response

Operating System

macOS

Python Executable

Conda

Python Version

3.11

Package Versions

No response

Code of Conduct
@rly rly mentioned this issue Oct 25, 2023
Merged
6 tasks
@rly
Copy link
Contributor Author

rly commented Oct 30, 2023

Fixed by #800

@rly rly closed this as completed Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rly