Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ruamel.yaml load call #1008

Merged
merged 5 commits into from
Dec 12, 2023
Merged

Update ruamel.yaml load call #1008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ae75cf1
Update validate_spec.py
rly Dec 7, 2023
c80a24a
Update CHANGELOG.md
rly Dec 7, 2023
52cef7d
Update validate_spec.py
rly Dec 7, 2023
27b10dd
Update validate_spec.py
rly Dec 7, 2023
99327f6
Merge branch 'dev' into rly-patch-1
rly Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

### Bug fixes
- Fixed issue with custom class generation when a spec has a `name`. @rly [#1006](https://github.com/hdmf-dev/hdmf/pull/1006)
- Fixed issue with usage of deprecated `ruamel.yaml.safe_load` in `src/hdmf/testing/validate_spec.py`. @rly [#1008](https://github.com/hdmf-dev/hdmf/pull/1008)

- Fixed issue where `ElementIdentifiers` data could be set to non-integer values. @rly [#1009](https://github.com/hdmf-dev/hdmf/pull/1009)

Expand Down
3 changes: 2 additions & 1 deletion src/hdmf/testing/validate_spec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ def __init__(self):
new_resolver = FixResolver()

f_nwb = open(fpath_spec, 'r')
instance = yaml.safe_load(f_nwb)
yaml_obj = yaml.YAML(typ='safe', pure=True)
instance = yaml_obj.load(f_nwb)

jsonschema.validate(instance, schema, resolver=new_resolver)

Expand Down