Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ruamel.yaml load call #1008

Merged
merged 5 commits into from
Dec 12, 2023
Merged

Update ruamel.yaml load call #1008

merged 5 commits into from
Dec 12, 2023

Conversation

rly
Copy link
Contributor

@rly rly commented Dec 7, 2023

Motivation

Fix #1007

How to test the behavior?

curl https://raw.githubusercontent.com/hdmf-dev/hdmf-common-schema/main/hdmf-common.schema.json > hdmf-common-schema.json
validate_hdmf_spec src/hdmf/hdmf-common-schema -m hdmf-common-schema.json

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

@rly rly requested a review from oruebel December 7, 2023 21:26
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.57%. Comparing base (b575e50) to head (99327f6).
Report is 84 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1008   +/-   ##
=======================================
  Coverage   88.57%   88.57%           
=======================================
  Files          45       45           
  Lines        9503     9503           
  Branches     2703     2703           
=======================================
  Hits         8417     8417           
  Misses        764      764           
  Partials      322      322           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly rly enabled auto-merge (squash) December 12, 2023 22:39
@rly rly merged commit cebb587 into dev Dec 12, 2023
28 checks passed
@rly rly deleted the rly-patch-1 branch December 12, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Replace yaml.safe_load after update to ruamel.yaml
2 participants