Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexible rpc secret file #2887

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions openvpn/start.sh
Original file line number Diff line number Diff line change
Expand Up @@ -219,8 +219,8 @@ else
fi

if [[ -f /run/secrets/rpc_creds ]]; then
export TRANSMISSION_RPC_USERNAME=$(head -1 /run/secrets/rpc_creds)
export TRANSMISSION_RPC_PASSWORD=$(tail -1 /run/secrets/rpc_creds)
export TRANSMISSION_RPC_USERNAME=$(sed -n '1p' /run/secrets/rpc_creds)
export TRANSMISSION_RPC_PASSWORD=$(sed -n '2p' /run/secrets/rpc_creds)
Comment on lines +222 to +223

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i set up this image recently and I was a bit surprised that these are not set individually with the possibility of using _FILE declarations.

fi
echo "${TRANSMISSION_RPC_USERNAME}" > /config/transmission-credentials.txt
echo "${TRANSMISSION_RPC_PASSWORD}" >> /config/transmission-credentials.txt
Expand Down