Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexible rpc secret file #2887

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

vic1707
Copy link

@vic1707 vic1707 commented Oct 19, 2024

Breaking change

<placeholder>

Proposed change

As some IDEs and text editors like to leave an empty blank line at the end of a file you can end up with an empty RPC password when using docker secrets.
This change ensure we are taking the password from se second line of the secret file, no matter how many lines it contains.
image

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to this container)
  • Breaking change (fix/feature causing existing functionality to break)

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue: relates to #
  • Link to documentation updated (if done separately): https://...

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated

@vic1707 vic1707 force-pushed the more-flexible-rpc-secret-file branch from 73c1386 to d7a6011 Compare October 19, 2024 12:28
Comment on lines +222 to +223
export TRANSMISSION_RPC_USERNAME=$(sed -n '1p' /run/secrets/rpc_creds)
export TRANSMISSION_RPC_PASSWORD=$(sed -n '2p' /run/secrets/rpc_creds)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i set up this image recently and I was a bit surprised that these are not set individually with the possibility of using _FILE declarations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants