Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate VoyagerView to TS #4734

Merged
merged 9 commits into from
May 20, 2020
Merged

Conversation

marekdano
Copy link
Contributor

Description

Migrate VoyageView to TS.

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR.

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

Related issue #4314.

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes
  • There are breaking changes:

@marekdano marekdano requested a review from a team as a code owner May 11, 2020 12:10
@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Hey @marekdano, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@netlify
Copy link

netlify bot commented May 11, 2020

Deploy preview for hasura-docs ready!

Built with commit b4661ac

https://deploy-preview-4734--hasura-docs.netlify.app

@hasura-bot
Copy link
Contributor

Review app for commit b4661ac deployed to Heroku: https://hge-ci-pull-4734.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4734-b4661ac3

@hasura-bot
Copy link
Contributor

Review app for commit a701830 deployed to Heroku: https://hge-ci-pull-4734.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4734-a7018303

Copy link
Contributor

@beerose beerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! 🎉

Looks great, approving!

@hasura-bot
Copy link
Contributor

Review app for commit c4a7ece deployed to Heroku: https://hge-ci-pull-4734.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4734-c4a7ece3

@beerose beerose requested a review from rikinsk May 15, 2020 11:16
@hasura-bot
Copy link
Contributor

Review app for commit 5840dee deployed to Heroku: https://hge-ci-pull-4734.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4734-5840dee6

@rikinsk
Copy link
Member

rikinsk commented May 19, 2020

@beerose Can you check the test failure here. It seems to be consistently failing

@beerose
Copy link
Contributor

beerose commented May 19, 2020

@rikinsk Looks like some CircleCI problem. WIll check

@hasura-bot
Copy link
Contributor

Review app for commit 05f4343 deployed to Heroku: https://hge-ci-pull-4734.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4734-05f4343d

Aleksandra Sikora added 2 commits May 19, 2020 22:08
@hasura-bot
Copy link
Contributor

Review app for commit 09dd7d1 deployed to Heroku: https://hge-ci-pull-4734.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4734-09dd7d18

@beerose
Copy link
Contributor

beerose commented May 19, 2020

@rikinsk This was a problem with better-npm-run that we're using. Here's an issue with a similar error: benoror/better-npm-run#79
I triggered cached node_modules update in CircleCI as short term solution, but as this package is deprecated, we should get rid of it.
Created an issue for it: https://github.com/hasura/graphql-engine-internal/issues/422

@hasura-bot
Copy link
Contributor

Review app for commit 0eba33a deployed to Heroku: https://hge-ci-pull-4734.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4734-0eba33a0

@hasura-bot
Copy link
Contributor

Review app for commit ce4054b deployed to Heroku: https://hge-ci-pull-4734.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4734-ce4054b2

@rikinsk rikinsk merged commit 289ff5e into hasura:master May 20, 2020
@hasura-bot
Copy link
Contributor

Beep boop! 🤖

GIF

Awesome work @marekdano! All of us at Hasura ❤️ what you did.

Thanks again 🤗

@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-4734.herokuapp.com is deleted

stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants