-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate VoyagerView to TS #4734
Conversation
Beep boop! 🤖 Hey @marekdano, thanks for your PR! One of my human friends will review this PR and get back to you as soon as possible. Stay awesome! 😎 |
Deploy preview for hasura-docs ready! Built with commit b4661ac |
Review app for commit b4661ac deployed to Heroku: https://hge-ci-pull-4734.herokuapp.com |
Review app for commit a701830 deployed to Heroku: https://hge-ci-pull-4734.herokuapp.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR! 🎉
Looks great, approving!
Review app for commit c4a7ece deployed to Heroku: https://hge-ci-pull-4734.herokuapp.com |
Review app for commit 5840dee deployed to Heroku: https://hge-ci-pull-4734.herokuapp.com |
@beerose Can you check the test failure here. It seems to be consistently failing |
@rikinsk Looks like some CircleCI problem. WIll check |
Review app for commit 05f4343 deployed to Heroku: https://hge-ci-pull-4734.herokuapp.com |
…hql-engine into migrate-voyagerview-to-ts
Review app for commit 09dd7d1 deployed to Heroku: https://hge-ci-pull-4734.herokuapp.com |
@rikinsk This was a problem with |
Review app for commit 0eba33a deployed to Heroku: https://hge-ci-pull-4734.herokuapp.com |
Review app for commit ce4054b deployed to Heroku: https://hge-ci-pull-4734.herokuapp.com |
Beep boop! 🤖 Awesome work @marekdano! All of us at Hasura ❤️ what you did. Thanks again 🤗 |
Review app https://hge-ci-pull-4734.herokuapp.com is deleted |
Description
Migrate VoyageView to TS.
Changelog
CHANGELOG.md
is updated with user-facing content relevant to this PR.Affected components
Related Issues
Related issue #4314.
Catalog upgrade
Does this PR change Hasura Catalog version?
Metadata
Does this PR add a new Metadata feature?
run_sql
auto manages the new metadata through schema diffing?run_sql
auto manages the definitions of metadata on renaming?export_metadata
/replace_metadata
supports the new metadata added?GraphQL
Breaking changes