Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console: migrate to TypeScript #4314

Closed
21 of 46 tasks
beerose opened this issue Apr 6, 2020 · 68 comments
Closed
21 of 46 tasks

console: migrate to TypeScript #4314

beerose opened this issue Apr 6, 2020 · 68 comments
Labels
c/console Related to console good first issue Good for newcomers help wanted Good candidate for contribution. Community help wanted!

Comments

@beerose
Copy link
Contributor

beerose commented Apr 6, 2020

As we merged #3902 recently we plan to gradually migrate frontend code to TypeScript.

Console codebase is pretty large, so we would love your help! 💪

How to contribute?

  1. Convert file from .js to .ts or .tsx.
  2. Add types, fix all type errors.
  3. Submit a PR! 🎉

Here you can find a guide on how to contribute to Hasura console.

We recommend you to take a look at the codebase and find something that is still in JS and seems interesting for you to migrate. If you find something, just let us know in the comment and go ahead! 😎

Click to see the list of easy and small modules that are a good fit for the start
Click to see the list of modules already migrated by the community 🙌

Reach out to us!

Feel free to reach if you have questions or need help getting started. You can leave comments here or you can tag me in your PR if you need any help or you're not sure about something!

You can also get in touch on our Discord #contrib channel.


To avoid duplicate work please comment on which part you want to work on (as long as nobody else is working on it) so we can mark it as taken.

@shahidhk shahidhk added c/console Related to console good first issue Good for newcomers help wanted Good candidate for contribution. Community help wanted! labels Apr 7, 2020
@alioguzhan
Copy link
Contributor

alioguzhan commented Apr 7, 2020

Hey,

I want to work on Theme and AlertBox. You can assign those to me.

PS: I will also convert the Typography components.

@kawamataryo
Copy link
Contributor

kawamataryo commented Apr 10, 2020

Hi,
I'd like to work on Button component.


P.S 2020/04/12

There was a point in the button migration that I didn't understand, so I'll do this first.

  • Checkbox component
  • Icon component
  • RadioButton component

@kawamataryo
Copy link
Contributor

I'd like to work on Spinner and SwitchButton component.

@ngprnk
Copy link

ngprnk commented Apr 22, 2020

I'd like to work on tooltip and Routes utils.

@mubaidr
Copy link
Contributor

mubaidr commented Apr 22, 2020

I would like to work on sql utils, graphql utils and main utils, please.

@irshadjsr21
Copy link
Contributor

I'd like to work on the Modal component, please assign it to me.

@sensiblefolk
Copy link

I would like to work on the alert box component

@beerose
Copy link
Contributor Author

beerose commented Apr 22, 2020

Hi, @sensiblefolk, AlertBox is already taken. I hope you can find something else. 😊

@sensiblefolk
Copy link

I can work on button, tabs or ace components

@beerose
Copy link
Contributor Author

beerose commented Apr 22, 2020

@sensiblefolk Let's leave button for @kawamataryo (he mentioned he'd like to work on it) and I'll assign you to tabs and ace components. Is it okay?

@sensiblefolk
Copy link

Let's leave button for @kawamataryo (he mentioned he'd like to work on it) and I'll assign you to tabs for now and ace components. Is it okay?

Yes it is okay

@alioguzhan
Copy link
Contributor

Hey @beerose, I am afraid I don't have enough time for AlertBox next a few days. I don't want to interrupt the conversion process. So we can assign AlertBox to @sensiblefolk if he still wants it.

What do you think?

@harishm72
Copy link
Contributor

Hi @beerose can I work on AlertBox and Headers Component and utils

@beerose
Copy link
Contributor Author

beerose commented Apr 22, 2020

Thanks for the information @alioguzhan!

Since @sensiblefolk already has a lot, I will assign @harishm72 to AlertBox and Headers Component and utils.

And... looks like I need to add more modules to the list! 🎉

@irshadjsr21
Copy link
Contributor

Is anyone working on configuring react-bootstrap with typescript? I tried but got an error while compiling the code. I also found an issue related to the problem. DefinitelyTyped/DefinitelyTyped#20021. Maybe any of you can solve it.

@beerose
Copy link
Contributor Author

beerose commented Apr 23, 2020

Hi @irshadjsr21!

I just tried downgrading @types/react-bootstrap and found out that with @types/react-bootstrap version "0.32.21" lib directory is properly included in node_modules.

So you can try to install the typings in this particular version and pin it in package.json 😉

@marekdano
Copy link
Contributor

Hi @beerose,
I can see that there are two components left now. I think I can take the Error boundary one. Is it ok?

@beerose
Copy link
Contributor Author

beerose commented Apr 23, 2020

Sure @marekdano! Assigning you to ErrorBoundary.

@fkhadra
Copy link
Contributor

fkhadra commented Apr 23, 2020

Hey @beerose, as GqlCompatibilityWarning component is the only one left. I would be happy to work on it.

@marekdano
Copy link
Contributor

@beerose please free to assign Routes.js to me

@hasura hasura deleted a comment from stevensule May 28, 2020
@hasura hasura deleted a comment May 28, 2020
@hasura hasura deleted a comment May 28, 2020
@hasura hasura deleted a comment May 28, 2020
@gokulchandra
Copy link
Contributor

@beerose I can pickup the work for Settings Actions.

@ryands17
Copy link
Contributor

ryands17 commented Jun 9, 2020

Hi @beerose :)
Are there any other React components that require conversion?

@beerose
Copy link
Contributor Author

beerose commented Jun 9, 2020

Hi @ryands17!
There are probably many, but not yet on the list. I can update this list in some time, but if you want you could also take a look at the console code and find something that seems cool to you! If you do, let me know, I'll add it to the list 😉

@ryands17
Copy link
Contributor

@beerose I can take on all the remaining .js files in the utils folder and apart from that the InputChecker component :)

@marekdano
Copy link
Contributor

Hi, @beerose! Are there any components or JS files that should be converted to TS?

@beerose
Copy link
Contributor Author

beerose commented Jun 26, 2020

Hi @marekdano! I guess most the easy and small ones were migrated, so now we can take care of the rest. It would be cool if you just go through the codebase and check if there's something that seems interesting for you to convert. 😉

@lautapercuspain
Copy link
Contributor

lautapercuspain commented Jul 30, 2020

Hi @beerose!

Is it ok if I start working on migrating src/components/Login/Actions.js to src/components/Login/Actions.ts?

@beerose
Copy link
Contributor Author

beerose commented Jul 30, 2020

Sure @lautapercuspain! 🙂

@gokulchandra
Copy link
Contributor

@beerose Just wondering if this PR for migrating settings actions to typescript can be reviewed?

#5028

@beerose
Copy link
Contributor Author

beerose commented Aug 11, 2020

I just reviewed it @gokulchandra. Sorry for the delay.

@harishm72
Copy link
Contributor

@beerose #4721 too

@lautapercuspain
Copy link
Contributor

lautapercuspain commented Aug 11, 2020

HI @beerose Just wondering if this one is ready to go? #5499

@k-herm
Copy link

k-herm commented Apr 26, 2021

Hi @beerose ! Updated 3 common components: EditableHeading, CustomInputAutoSuggest, KnowMoreLink #6818

@NoriSte
Copy link
Contributor

NoriSte commented Oct 4, 2022

The Console currently breaks for unpredictable behaviours (we are internally working to fix it), that's why I generically discourage working on the Console, even for the smaller TS upgrades (we are working on them too). I close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/console Related to console good first issue Good for newcomers help wanted Good candidate for contribution. Community help wanted!
Projects
None yet
Development

No branches or pull requests