Add ByteArray generation #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Bodigrim Let me know what you think about this PR if and when you have some time. |
|
@lehins overall looks great! Could you possibly organise code mentioning |
lehins
force-pushed
the
lehins/extend-frozen-gen
branch
from
2fba77c to
66f0f10
Compare
lehins
force-pushed
the
lehins/extend-frozen-gen
branch
4 times, most recently
from
c7eb9bd to
bc58313
Compare
lehins
force-pushed
the
lehins/bytearray
branch
from
b8c0ae4 to
324069a
Compare
lehins
force-pushed
the
lehins/bytearray
branch
2 times, most recently
from
53909ce to
9dd6ca4
Compare
@Bodigrim I am not sure I understand in which way you'd like it to be organized. All of the ByteArray/ShortByteString/ByteString functionality is together in the same part of the module. It probably doesn't look like that in the diff, because some of the |
lehins
force-pushed
the
lehins/bytearray
branch
5 times, most recently
from
c3e6fd6 to
380e221
Compare
Also fixup example with `FrozenGen` instance in haddock
lehins
force-pushed
the
lehins/bytearray
branch
2 times, most recently
from
8a7d6a9 to
cc7a818
Compare
* Switch to using `ByteArray` for type class implementation instead of `ShortByteString` * Add `unsafeUniformFillMutableByteArray` to `RandomGen` and a helper function `defaultUnsafeUniformFillMutableByteArray` that makes implementation for most instances easier. * Add `uniformByteArray`, `uniformByteString` and `uniformFillMutableByteArray` * Add `uniformByteArrayM` to `StatefulGen` * Add `uniformByteStringM` and `uniformShortByteStringM` * Deprecate `uniformShortByteString` in favor of `uniformShortByteStringM` for consistent naming and a future plan of removing it from `StatefulGen` type class * Expose a helper function `genByteArrayST`, that can be used for defining implementation for `uniformByteArrayM`
lehins
force-pushed
the
lehins/bytearray
branch
from
cc7a818 to
8267ce8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #142 and more.
Add compatibility with recently added
ByteArrayto base and fallback ontodata-array-bytepackage for older ghc versions.Besides this we also:
MutableByteArray, instead of creating an immutableByteArray. This can help avoid allocations in some situations when array has already been preallocated.ByteArrays.