-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust for new additions in upcoming random-1.3 #89
Open
lehins
wants to merge
15
commits into
haskell:master
Choose a base branch
from
lehins:lehins/random-1.3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would be better to drop support fot haskellGH-7.10, but this is more controversial, so instead we add some CPP
lehins
force-pushed
the
lehins/random-1.3
branch
from
November 24, 2023 17:00
6d11ba7
to
3100be7
Compare
lehins
force-pushed
the
lehins/random-1.3
branch
from
November 24, 2023 17:36
3100be7
to
4a351dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @Shimuuar I am working on some changes in the
random-1.3
stateful interface in haskell/random#153 Could you take a look and see if you find it sensible.Addition of
modifyGen
is more useful for stateful generators that are regular wrappers aroundRandomGen
rather than for the ones like mwc implements. It also allows for a mutableGen
to be overwritten with theSeed
usingoverwriteGen
Depends on #88