-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deer
: implement Deserialize
for core::cell
#2376
Merged
Merged
+185
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2376 +/- ##
==========================================
+ Coverage 60.69% 60.72% +0.02%
==========================================
Files 317 317
Lines 24279 24275 -4
Branches 421 421
==========================================
+ Hits 14737 14741 +4
+ Misses 9537 9529 -8
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced Apr 10, 2023
TimDiekmann
previously approved these changes
Apr 12, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Apr 13, 2023
TimDiekmann
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌟 What is the purpose of this PR?
This is an "explosion" of #1875 and implements
Deserialize
for:core::cell::Cell
core::cell::RefCell
core::cell::UnsafeCell
core::cell::OnceCell
core::cell::SyncUnsafeCell
🔗 Related links
deer
type implementation #1700deer
implementDeserialize
for built-in types (Part 2) #1875🔍 Has this modified a publishable library?
This PR: