Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deer: implement Deserialize for core::sync #2386

Merged
merged 14 commits into from
Apr 13, 2023
Merged

deer: implement Deserialize for core::sync #2386

merged 14 commits into from
Apr 13, 2023

Conversation

indietyp
Copy link
Member

🌟 What is the purpose of this PR?

Implements Deserialize for:

Based upon #2376, the new low-level assertion function is needed because PartialEq is not implemented on Exclusive.

🔗 Related links

🔍 Has this modified a publishable library?

This PR:

  • modifies an npm-publishable library and I have added a changeset file(s)
  • modifies a Cargo-publishable library and I have amended the version
  • modifies a Cargo-publishable library, but it is not yet ready to publish
  • modifies a block that will need publishing via GitHub action once merged
  • does not modify any publishable blocks or libraries
  • I am unsure / need advice

@indietyp indietyp requested a review from a team as a code owner April 10, 2023 16:15
@github-actions github-actions bot added the area/libs > deer Affects the `deer` crate (library) label Apr 10, 2023
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Merging #2386 (de3620d) into main (a92b712) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2386   +/-   ##
=======================================
  Coverage   56.76%   56.77%           
=======================================
  Files         336      337    +1     
  Lines       26012    26015    +3     
  Branches      421      421           
=======================================
+ Hits        14766    14769    +3     
  Misses      11241    11241           
  Partials        5        5           
Flag Coverage Δ
backend-integration-tests 3.66% <ø> (ø)
deer 69.24% <100.00%> (+0.02%) ⬆️
unit-tests 1.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/deer/src/impls/core/sync/atomic.rs 0.00% <ø> (ø)
libs/deer/src/lib.rs 73.80% <ø> (ø)
libs/deer/src/impls/core/sync.rs 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

TimDiekmann
TimDiekmann previously approved these changes Apr 12, 2023
Base automatically changed from bm/deer/core-cell to main April 13, 2023 12:30
Merged via the queue into main with commit 3bf4fa1 Apr 13, 2023
@indietyp indietyp deleted the bm/deer/core-sync branch April 13, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/libs > deer Affects the `deer` crate (library)
Development

Successfully merging this pull request may close these issues.

2 participants