Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 1.18.x: UI Solve cntrl+f issue on KVv2 JSON details and edit views (#28808) #28893

Merged
merged 5 commits into from
Nov 25, 2024

Commits on Nov 12, 2024

  1. Solve cntrl+f issue on KVv2 JSON details and edit views (#28808)

    * initial changes need to add test coverage
    
    * change icon
    
    * replace original idea with hds::codeblock on kvv2 details view
    
    * changelog
    
    * fixing edit view by addressing viewportMargin
    
    * fix failing test
    
    * missedone
    
    * Update 28808.txt
    
    * Update json-editor.js
    
    * test coverage
    
    * update codeblock selector
    
    * Update general-selectors.ts
    
    * Update kv-data-fields.js
    
    * Update ui/lib/core/addon/components/json-editor.js
    
    Co-authored-by: claire bontempo <[email protected]>
    
    * Update ui/lib/kv/addon/components/kv-data-fields.js
    
    Co-authored-by: claire bontempo <[email protected]>
    
    * update test name
    
    * add default to modifier
    
    ---------
    
    Co-authored-by: claire bontempo <[email protected]>
    Monkeychip and hellobontempo committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    5041e7c View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Configuration menu
    Copy the full SHA
    8eedad8 View commit details
    Browse the repository at this point in the history
  2. Update accounts-test.js

    return to original test
    Monkeychip authored Nov 25, 2024
    Configuration menu
    Copy the full SHA
    416dfc6 View commit details
    Browse the repository at this point in the history
  3. Update accounts.hbs

    Monkeychip authored Nov 25, 2024
    Configuration menu
    Copy the full SHA
    df57a6b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    230a397 View commit details
    Browse the repository at this point in the history