Backport 1.18.x: UI Solve cntrl+f issue on KVv2 JSON details and edit views (#28808) #28893
+203
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* initial changes need to add test coverage * change icon * replace original idea with hds::codeblock on kvv2 details view * changelog * fixing edit view by addressing viewportMargin * fix failing test * missedone * Update 28808.txt * Update json-editor.js * test coverage * update codeblock selector * Update general-selectors.ts * Update kv-data-fields.js * Update ui/lib/core/addon/components/json-editor.js Co-authored-by: claire bontempo <[email protected]> * Update ui/lib/kv/addon/components/kv-data-fields.js Co-authored-by: claire bontempo <[email protected]> * update test name * add default to modifier --------- Co-authored-by: claire bontempo <[email protected]>
github-actions
bot
added
the
hashicorp-contributed-pr
Monkeychip
added
backport/ent/1.16.x+ent
|
Build Results: |
|
CI Results: failed ❌ |
emoncuso
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed the 1.18.2 cut off, waiting to merge until release branch freeze is over.
Manual backport of #28808