Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new resource azurerm_stack_hci_network_interface #26888

Merged
merged 17 commits into from
Nov 8, 2024
Merged
Show file tree
Hide file tree
Changes from 12 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/services/azurestackhci/registration.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ func (r Registration) Resources() []sdk.Resource {
return []sdk.Resource{
StackHCIDeploymentSettingResource{},
StackHCILogicalNetworkResource{},
StackHCINetworkInterfaceResource{},
StackHCIStoragePathResource{},
StackHCIVirtualHardDiskResource{},
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,351 @@
package azurestackhci

import (
"context"
"fmt"
"regexp"
"time"

"github.com/hashicorp/go-azure-helpers/lang/pointer"
"github.com/hashicorp/go-azure-helpers/lang/response"
"github.com/hashicorp/go-azure-helpers/resourcemanager/commonschema"
"github.com/hashicorp/go-azure-helpers/resourcemanager/location"
"github.com/hashicorp/go-azure-helpers/resourcemanager/tags"
"github.com/hashicorp/go-azure-sdk/resource-manager/azurestackhci/2024-01-01/logicalnetworks"
"github.com/hashicorp/go-azure-sdk/resource-manager/azurestackhci/2024-01-01/networkinterfaces"
"github.com/hashicorp/go-azure-sdk/resource-manager/extendedlocation/2021-08-15/customlocations"
"github.com/hashicorp/terraform-provider-azurerm/internal/sdk"
"github.com/hashicorp/terraform-provider-azurerm/internal/tf/pluginsdk"
"github.com/hashicorp/terraform-provider-azurerm/internal/tf/validation"
)

var (
_ sdk.Resource = StackHCINetworkInterfaceResource{}
_ sdk.ResourceWithUpdate = StackHCINetworkInterfaceResource{}
)

type StackHCINetworkInterfaceResource struct{}

func (StackHCINetworkInterfaceResource) IDValidationFunc() pluginsdk.SchemaValidateFunc {
return networkinterfaces.ValidateNetworkInterfaceID
}

func (StackHCINetworkInterfaceResource) ResourceType() string {
return "azurerm_stack_hci_network_interface"
}

func (StackHCINetworkInterfaceResource) ModelObject() interface{} {
return &StackHCINetworkInterfaceResourceModel{}
}

type StackHCINetworkInterfaceResourceModel struct {
Name string `tfschema:"name"`
ResourceGroupName string `tfschema:"resource_group_name"`
Location string `tfschema:"location"`
CustomLocationId string `tfschema:"custom_location_id"`
DNSServers []string `tfschema:"dns_servers"`
IPConfiguration []StackHCIIPConfigurationModel `tfschema:"ip_configuration"`
MACAddress string `tfschema:"mac_address"`
Tags map[string]interface{} `tfschema:"tags"`
}

type StackHCIIPConfigurationModel struct {
Gateway string `tfschema:"gateway"`
PrefixLength string `tfschema:"prefix_length"`
PrivateIPAddress string `tfschema:"private_ip_address"`
SubnetID string `tfschema:"subnet_id"`
}

func (StackHCINetworkInterfaceResource) Arguments() map[string]*pluginsdk.Schema {
return map[string]*pluginsdk.Schema{
"name": {
Type: pluginsdk.TypeString,
Required: true,
ForceNew: true,
ValidateFunc: validation.StringMatch(
regexp.MustCompile(`^[a-zA-Z0-9][\-\.\_a-zA-Z0-9]{0,78}[a-zA-Z0-9]$`),
"name must be between 2 and 80 characters and can only contain alphanumberic characters, hyphens(-), periods(.) and underlines(_). It must begin and end with an alphanumberic character.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would something like this be more clear?

Suggested change
"name must be between 2 and 80 characters and can only contain alphanumberic characters, hyphens(-), periods(.) and underlines(_). It must begin and end with an alphanumberic character.",
"name must begin and end with an alphanumeric character, be between 2 and 80 characters in length and can only contain alphanumeric characters, hyphens, periods or underscores.",

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teowa, sorry I forgot to add the description to my review. I took a look a think this mostly LGTM. If we can get the validation function error message fixed up I think this would be GTG! 🚀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing this, the code is updated, please kindly take another look.

),
},

"resource_group_name": commonschema.ResourceGroupName(),

"location": commonschema.Location(),

"custom_location_id": commonschema.ResourceIDReferenceRequiredForceNew(&customlocations.CustomLocationId{}),

"ip_configuration": {
Type: pluginsdk.TypeList,
Required: true,
ForceNew: true,
MaxItems: 1,
Elem: &pluginsdk.Resource{
Schema: map[string]*pluginsdk.Schema{
"subnet_id": commonschema.ResourceIDReferenceRequiredForceNew(&logicalnetworks.LogicalNetworkId{}),

"private_ip_address": {
Type: pluginsdk.TypeString,
Optional: true,
ForceNew: true,
ValidateFunc: validation.IsIPv4Address,
},

"gateway": {
Type: pluginsdk.TypeString,
Computed: true,
},

"prefix_length": {
Type: pluginsdk.TypeString,
Computed: true,
},
},
},
},

"dns_servers": {
Type: pluginsdk.TypeList,
Optional: true,
ForceNew: true,
MinItems: 1,
Elem: &pluginsdk.Schema{
Type: pluginsdk.TypeString,
ValidateFunc: validation.IsIPv4Address,
},
},

"mac_address": {
Type: pluginsdk.TypeString,
Optional: true,
ForceNew: true,
ValidateFunc: validation.StringIsNotEmpty,
},

"tags": commonschema.Tags(),
}
}

func (StackHCINetworkInterfaceResource) Attributes() map[string]*pluginsdk.Schema {
return map[string]*pluginsdk.Schema{}
}

func (r StackHCINetworkInterfaceResource) Create() sdk.ResourceFunc {
return sdk.ResourceFunc{
Timeout: 30 * time.Minute,
Func: func(ctx context.Context, metadata sdk.ResourceMetaData) error {
client := metadata.Client.AzureStackHCI.NetworkInterfaces

var config StackHCINetworkInterfaceResourceModel
if err := metadata.Decode(&config); err != nil {
return fmt.Errorf("decoding: %+v", err)
}

subscriptionId := metadata.Client.Account.SubscriptionId
id := networkinterfaces.NewNetworkInterfaceID(subscriptionId, config.ResourceGroupName, config.Name)

existing, err := client.Get(ctx, id)
if err != nil && !response.WasNotFound(existing.HttpResponse) {
return fmt.Errorf("checking for presence of existing %s: %+v", id, err)
}
if !response.WasNotFound(existing.HttpResponse) {
return metadata.ResourceRequiresImport(r.ResourceType(), id)
}

payload := networkinterfaces.NetworkInterfaces{
Name: pointer.To(config.Name),
Location: location.Normalize(config.Location),
Tags: tags.Expand(config.Tags),
ExtendedLocation: &networkinterfaces.ExtendedLocation{
Name: pointer.To(config.CustomLocationId),
Type: pointer.To(networkinterfaces.ExtendedLocationTypesCustomLocation),
},
Properties: &networkinterfaces.NetworkInterfaceProperties{
IPConfigurations: expandStackHCINetworkInterfaceIPConfiguration(config.IPConfiguration),
},
}

if config.MACAddress != "" {
payload.Properties.MacAddress = pointer.To(config.MACAddress)
}

if len(config.DNSServers) != 0 {
payload.Properties.DnsSettings = &networkinterfaces.InterfaceDNSSettings{
DnsServers: pointer.To(config.DNSServers),
}
}

if err := client.CreateOrUpdateThenPoll(ctx, id, payload); err != nil {
return fmt.Errorf("performing create %s: %+v", id, err)
}

metadata.SetID(id)

return nil
},
}
}

func (r StackHCINetworkInterfaceResource) Read() sdk.ResourceFunc {
return sdk.ResourceFunc{
Timeout: 5 * time.Minute,
Func: func(ctx context.Context, metadata sdk.ResourceMetaData) error {
client := metadata.Client.AzureStackHCI.NetworkInterfaces

id, err := networkinterfaces.ParseNetworkInterfaceID(metadata.ResourceData.Id())
if err != nil {
return err
}

resp, err := client.Get(ctx, *id)
if err != nil {
if response.WasNotFound(resp.HttpResponse) {
return metadata.MarkAsGone(id)
}

return fmt.Errorf("retrieving %s: %+v", id, err)
}

schema := StackHCINetworkInterfaceResourceModel{
Name: id.NetworkInterfaceName,
ResourceGroupName: id.ResourceGroupName,
}

if model := resp.Model; model != nil {
schema.Location = location.Normalize(model.Location)
schema.Tags = tags.Flatten(model.Tags)

if model.ExtendedLocation != nil && model.ExtendedLocation.Name != nil {
customLocationId, err := customlocations.ParseCustomLocationIDInsensitively(*model.ExtendedLocation.Name)
if err != nil {
return err
}

schema.CustomLocationId = customLocationId.ID()
}

if props := model.Properties; props != nil {
schema.MACAddress = pointer.From(props.MacAddress)

ipConfiguration, err := flattenStackHCINetworkInterfaceIPConfiguration(props.IPConfigurations)
if err != nil {
return err
}
schema.IPConfiguration = ipConfiguration

if props.DnsSettings != nil {
schema.DNSServers = pointer.From(props.DnsSettings.DnsServers)
}
}
}

return metadata.Encode(&schema)
},
}
}

func (r StackHCINetworkInterfaceResource) Update() sdk.ResourceFunc {
return sdk.ResourceFunc{
Timeout: 30 * time.Minute,
Func: func(ctx context.Context, metadata sdk.ResourceMetaData) error {
client := metadata.Client.AzureStackHCI.NetworkInterfaces

id, err := networkinterfaces.ParseNetworkInterfaceID(metadata.ResourceData.Id())
if err != nil {
return err
}

var model StackHCINetworkInterfaceResourceModel
if err := metadata.Decode(&model); err != nil {
return fmt.Errorf("decoding: %+v", err)
}

parameters := networkinterfaces.NetworkInterfacesUpdateRequest{}

if metadata.ResourceData.HasChange("tags") {
parameters.Tags = tags.Expand(model.Tags)
}

if err := client.UpdateThenPoll(ctx, *id, parameters); err != nil {
return fmt.Errorf("updating %s: %+v", id, err)
}
return nil
},
}
}

func (r StackHCINetworkInterfaceResource) Delete() sdk.ResourceFunc {
return sdk.ResourceFunc{
Timeout: 30 * time.Minute,
Func: func(ctx context.Context, metadata sdk.ResourceMetaData) error {
client := metadata.Client.AzureStackHCI.NetworkInterfaces

id, err := networkinterfaces.ParseNetworkInterfaceID(metadata.ResourceData.Id())
if err != nil {
return err
}

if err := client.DeleteThenPoll(ctx, *id); err != nil {
return fmt.Errorf("deleting %s: %+v", id, err)
}

return nil
},
}
}

func expandStackHCINetworkInterfaceIPConfiguration(input []StackHCIIPConfigurationModel) *[]networkinterfaces.IPConfiguration {
if len(input) == 0 {
return nil
}

results := make([]networkinterfaces.IPConfiguration, 0)
for _, v := range input {
result := networkinterfaces.IPConfiguration{
Properties: &networkinterfaces.IPConfigurationProperties{
Subnet: &networkinterfaces.IPConfigurationPropertiesSubnet{
Id: pointer.To(v.SubnetID),
},
},
}

if v.PrivateIPAddress != "" {
result.Properties.PrivateIPAddress = pointer.To(v.PrivateIPAddress)
}

results = append(results, result)
}

return &results
}

func flattenStackHCINetworkInterfaceIPConfiguration(input *[]networkinterfaces.IPConfiguration) ([]StackHCIIPConfigurationModel, error) {
if input == nil {
return make([]StackHCIIPConfigurationModel, 0), nil
}

results := make([]StackHCIIPConfigurationModel, 0)
for _, v := range *input {
result := StackHCIIPConfigurationModel{}

if v.Properties != nil {
result.Gateway = pointer.From(v.Properties.Gateway)
result.PrefixLength = pointer.From(v.Properties.PrefixLength)
result.PrivateIPAddress = pointer.From(v.Properties.PrivateIPAddress)

var subnetId string
if v.Properties.Subnet != nil && v.Properties.Subnet.Id != nil {
parsedSubnetId, err := logicalnetworks.ParseLogicalNetworkIDInsensitively(*v.Properties.Subnet.Id)
if err != nil {
return results, err
}

subnetId = parsedSubnetId.ID()
}
result.SubnetID = subnetId

results = append(results, result)
}
}

return results, nil
}
Loading
Loading